[ZOOKEEPER-2019] Unhandled exception when setting invalid limits data in /zookeeper/quota/some/path/zookeeper_limits

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Component/s: server
• Assignee: Raúl Gutiérrez Segalés
• Reporter: Raúl Gutiérrez Segalés
• Created: 22/Aug/14 23:23
• Updated: 15/Jun/23 21:09

Description

If you have quotas properly set for a given path, i.e.:

create /zookeeper/quota/test/zookeeper_limits 'count=1,bytes=100'
create /zookeeper/quota/test/zookeeper_stats 'count=1,bytes=100'

and then you update the limits znode with bogus data, i.e.:

set /zookeeper/quota/test/zookeeper_limits ''

you'll crash the cluster because IllegalArgumentException isn't handled when dealing with quotas znodes:

https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L379
https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L425

We should handle IllegalArgumentException. Optionally, we should also throw BadArgumentsException from PrepRequestProcessor.

Review Board: https://reviews.apache.org/r/25968/