[ZOOKEEPER-1998] C library calls getaddrinfo unconditionally from zookeeper_interest

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.7.0
• Component/s: c client
• Labels: pull-request-available
• Assignee: Damien Diederen
• Reporter: Raúl Gutiérrez Segalés
• Created: 29/Jul/14 19:27
• Updated: 28/Mar/21 08:55
• Resolved: 17/May/20 13:17

Description

(commented this on ZOOKEEPER-338)

I've just noticed that we call getaddrinfo from zookeeper_interest... on every call. So from zookeeper_interest we always call update_addrs:

https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L2082

which in turns unconditionally calls resolve_hosts:

https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L787

which does the unconditional calls to getaddrinfo:

https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L648

We should fix this since it'll make 3.5.0 slower for people relying on DNS. I think this is happened as part of ZOOKEEPER-107 in which the list of servers can be updated.

cc: shralex, phunt, fpj

Issue Links

• blocks: MESOS-2681 Slave process must restart to update ensemble members
• is duplicated by: ZOOKEEPER-2965 prevent DNS queries spam
• links to: GitHub Pull Request #1068