[ZOOKEEPER-1981] Fix Dodgy Code Warnings identified by findbugs 2.0.3

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.5.0
• Hadoop Flags: Reviewed
• Assignee: Hongchao Deng
• Reporter: Hongchao Deng
• Created: 21/Jul/14 16:45
• Updated: 22/Jul/14 11:31
• Resolved: 22/Jul/14 04:51

Description

There are two cases:
1. a duplicate check of null bytes.
2. a lot switch statement without default case.

For the default case, I suggest
1. throwing an exception as a way to break the program. It's highly unexpected.
2. or LOG.warn it.

I am doing the second right now to keep the original.