ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1918

Add 64 bit Windows as a supported development platform

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Change this line:

      Win32 is supported as a development platform only for both server and client.

      to:

      Win32 and Win64 are supported as a development platform only for both server and client.

      http://zookeeper.apache.org/doc/trunk/zookeeperAdmin.html#sc_supportedPlatforms

      1. ZOOKEEPER-1918.patch
        0.8 kB
        Michi Mutsuzaki

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12641800/ZOOKEEPER-1918.patch
        against trunk revision 1588584.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2060//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2060//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2060//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641800/ZOOKEEPER-1918.patch against trunk revision 1588584. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2060//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2060//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2060//console This message is automatically generated.
        Hide
        Joe Gamache added a comment -

        I know I am not alone, but can we get PRODUCTION support for windows? If not, could you explain the reason?

        thanks!

        Show
        Joe Gamache added a comment - I know I am not alone, but can we get PRODUCTION support for windows? If not, could you explain the reason? thanks!
        Hide
        Michi Mutsuzaki added a comment -

        I wasn't involved in defining the support level, so I'll let other people answer the question. I personally don't understand what development support and production support mean.

        Show
        Michi Mutsuzaki added a comment - I wasn't involved in defining the support level, so I'll let other people answer the question. I personally don't understand what development support and production support mean.
        Hide
        Orion Hodson added a comment -

        Add solution and project files to enable build with current Visual Studio editions (VS 2012/2013) - 32-bit and 64-bit.

        Show
        Orion Hodson added a comment - Add solution and project files to enable build with current Visual Studio editions (VS 2012/2013) - 32-bit and 64-bit.
        Hide
        Orion Hodson added a comment -

        I've attached a patch that at enables the Windows build on currently available VS versions.

        To get closer to parity, we might be looking at:

        0) enable build with a recent version of Visual Studio - free editions exist that'll build the project files in the added patch (ZOOKEEPER-1918-VS2013.patch).

        1) Determine whether changes are needed in the tooling the Zookeeper project uses for automated builds, patch testing, etc. for recent VS editions.

        2) Get the C client unit tests running on Windows x86/x64 so it runs the same set of tests as other platforms.

        3) Investigate and clean-up the VS compiler warnings.

        4) Sanity check error handling on Windows.

        5) See if we can find a cleaner factoring of the Windows code to reduce amount of #ifdef's. Nice to have have, perhaps not essential.

        Is there anything else that should be on this list? I'm okay with putting in some cycles here, but it's very much a side effort and I'm pretty loaded with the day job.

        Thanks, Orion

        Show
        Orion Hodson added a comment - I've attached a patch that at enables the Windows build on currently available VS versions. To get closer to parity, we might be looking at: 0) enable build with a recent version of Visual Studio - free editions exist that'll build the project files in the added patch ( ZOOKEEPER-1918 -VS2013.patch). 1) Determine whether changes are needed in the tooling the Zookeeper project uses for automated builds, patch testing, etc. for recent VS editions. 2) Get the C client unit tests running on Windows x86/x64 so it runs the same set of tests as other platforms. 3) Investigate and clean-up the VS compiler warnings. 4) Sanity check error handling on Windows. 5) See if we can find a cleaner factoring of the Windows code to reduce amount of #ifdef's. Nice to have have, perhaps not essential. Is there anything else that should be on this list? I'm okay with putting in some cycles here, but it's very much a side effort and I'm pretty loaded with the day job. Thanks, Orion
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12652881/ZOOKEEPER-1918-VS2013.patch
        against trunk revision 1605517.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2158//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2158//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12652881/ZOOKEEPER-1918-VS2013.patch against trunk revision 1605517. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2158//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2158//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        I know I am not alone, but can we get PRODUCTION support for windows? If not, could you explain the reason?

        I wasn't involved in defining the support level, so I'll let other people answer the question. I personally don't understand what development support and production support mean.

        Some history/rational. The basic issue has been that the community primarily developed and deployed using Linux. There was some interest in windows, but not sufficient such that, say someone could work on an issue reported by a windows user. Perhaps we're at a point now where we have enough interest, I'm not sure.

        IMO "production support" doesn't mean much, other than perhaps that people feel confident enough in the current status that they are running it in production. Other folks can use that as an indication that "it works".

        Show
        Patrick Hunt added a comment - I know I am not alone, but can we get PRODUCTION support for windows? If not, could you explain the reason? I wasn't involved in defining the support level, so I'll let other people answer the question. I personally don't understand what development support and production support mean. Some history/rational. The basic issue has been that the community primarily developed and deployed using Linux. There was some interest in windows, but not sufficient such that, say someone could work on an issue reported by a windows user. Perhaps we're at a point now where we have enough interest, I'm not sure. IMO "production support" doesn't mean much, other than perhaps that people feel confident enough in the current status that they are running it in production. Other folks can use that as an indication that "it works".
        Hide
        Patrick Hunt added a comment -

        I moved the VS2013 to it's own jira - see ZOOKEEPER-1953.

        Show
        Patrick Hunt added a comment - I moved the VS2013 to it's own jira - see ZOOKEEPER-1953 .
        Hide
        Patrick Hunt added a comment -

        Committed to trunk, thanks Michi.

        Show
        Patrick Hunt added a comment - Committed to trunk, thanks Michi.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in ZooKeeper-trunk #2354 (See https://builds.apache.org/job/ZooKeeper-trunk/2354/)
        ZOOKEEPER-1918. Add 64 bit Windows as a supported development platform (Michi Mutsuzaki via phunt) (phunt: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607524)

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/docs/index.pdf
        • /zookeeper/trunk/docs/javaExample.pdf
        • /zookeeper/trunk/docs/linkmap.pdf
        • /zookeeper/trunk/docs/recipes.html
        • /zookeeper/trunk/docs/recipes.pdf
        • /zookeeper/trunk/docs/releasenotes.pdf
        • /zookeeper/trunk/docs/zookeeperAdmin.html
        • /zookeeper/trunk/docs/zookeeperAdmin.pdf
        • /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.pdf
        • /zookeeper/trunk/docs/zookeeperInternals.pdf
        • /zookeeper/trunk/docs/zookeeperJMX.pdf
        • /zookeeper/trunk/docs/zookeeperObservers.pdf
        • /zookeeper/trunk/docs/zookeeperOver.pdf
        • /zookeeper/trunk/docs/zookeeperProgrammers.html
        • /zookeeper/trunk/docs/zookeeperProgrammers.pdf
        • /zookeeper/trunk/docs/zookeeperQuotas.pdf
        • /zookeeper/trunk/docs/zookeeperStarted.html
        • /zookeeper/trunk/docs/zookeeperStarted.pdf
        • /zookeeper/trunk/docs/zookeeperTutorial.pdf
        • /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2354 (See https://builds.apache.org/job/ZooKeeper-trunk/2354/ ) ZOOKEEPER-1918 . Add 64 bit Windows as a supported development platform (Michi Mutsuzaki via phunt) (phunt: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607524 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/docs/index.pdf /zookeeper/trunk/docs/javaExample.pdf /zookeeper/trunk/docs/linkmap.pdf /zookeeper/trunk/docs/recipes.html /zookeeper/trunk/docs/recipes.pdf /zookeeper/trunk/docs/releasenotes.pdf /zookeeper/trunk/docs/zookeeperAdmin.html /zookeeper/trunk/docs/zookeeperAdmin.pdf /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.pdf /zookeeper/trunk/docs/zookeeperInternals.pdf /zookeeper/trunk/docs/zookeeperJMX.pdf /zookeeper/trunk/docs/zookeeperObservers.pdf /zookeeper/trunk/docs/zookeeperOver.pdf /zookeeper/trunk/docs/zookeeperProgrammers.html /zookeeper/trunk/docs/zookeeperProgrammers.pdf /zookeeper/trunk/docs/zookeeperQuotas.pdf /zookeeper/trunk/docs/zookeeperStarted.html /zookeeper/trunk/docs/zookeeperStarted.pdf /zookeeper/trunk/docs/zookeeperTutorial.pdf /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml

          People

          • Assignee:
            Michi Mutsuzaki
            Reporter:
            Michi Mutsuzaki
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development