ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1833 fix windows build
  3. ZOOKEEPER-1874

Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.0
    • Component/s: tests
    • Labels:
      None

      Description

      This jira to provide proper cleanups in ReconfigTest test cases.

      1. ZOOKEEPER-1874.patch
        4 kB
        Germán Blanco
      2. ZOOKEEPER-1874.patch
        4 kB
        Rakesh R

        Activity

        Hide
        Rakesh R added a comment -

        Attaching patch to do the quorumpeer cleanups after test execution.

        Show
        Rakesh R added a comment - Attaching patch to do the quorumpeer cleanups after test execution.
        Hide
        Rakesh R added a comment -

        Hi German/Flavio,
        I've attached patch, but again it requires proper eol:style also. Will you please have a look at it when you get sometime. Thanks

        Show
        Rakesh R added a comment - Hi German/Flavio, I've attached patch, but again it requires proper eol:style also. Will you please have a look at it when you get sometime. Thanks
        Hide
        Germán Blanco added a comment -

        let's see if this one works.

        Show
        Germán Blanco added a comment - let's see if this one works.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12626552/ZOOKEEPER-1874.patch
        against trunk revision 1561672.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12626552/ZOOKEEPER-1874.patch against trunk revision 1561672. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//console This message is automatically generated.
        Hide
        Germán Blanco added a comment -

        The changes look good to me.

        Show
        Germán Blanco added a comment - The changes look good to me.
        Hide
        Rakesh R added a comment -

        Thanks German for the patch. +1 lgtm

        Show
        Rakesh R added a comment - Thanks German for the patch. +1 lgtm
        Hide
        Michi Mutsuzaki added a comment -

        +1 Thank you Rakesh and Germán.

        Show
        Michi Mutsuzaki added a comment - +1 Thank you Rakesh and Germán.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in ZooKeeper-trunk #2213 (See https://builds.apache.org/job/ZooKeeper-trunk/2213/)
        ZOOKEEPER-1874 Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer (Rakesh R and Germán Blanco via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1567488)

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java
        Show
        Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2213 (See https://builds.apache.org/job/ZooKeeper-trunk/2213/ ) ZOOKEEPER-1874 Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer (Rakesh R and Germán Blanco via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1567488 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java

          People

          • Assignee:
            Unassigned
            Reporter:
            Rakesh R
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development