ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1833 fix windows build
  3. ZOOKEEPER-1858

JMX checks - potential race conditions while stopping and starting server

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.6, 3.5.0
    • Component/s: None
    • Labels:

      Description

      I've noticed one potential case, where previously created zkclient session immediately reconnected and publishing those beans while starting back the zkserver and affecting zk#startup jmx checks.

      Say, before stopping the server, there is a zk client session 0x143576544c50000 exists. While starting back the server, there could be possibility of seeing the client sessions in jmx. Following is one such case. Please see below logs which has taken from build https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/642/

          [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1228] - Session establishment complete on server 127.0.0.1/127.0.0.1:11222, sessionid = 0x143576544c50000, negotiated timeout = 30000
          [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11222:ZooKeeperServer@617] - Established session 0x143576544c50000 with negotiated timeout 30000 for client /127.0.0.1:55377
       [junit] 2014-01-03 09:18:12,391 [myid:] - INFO  [main:JMXEnv@135] - ensureOnly:[]
          [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@438] - STARTING server
          [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@359] - CREATING server instance 127.0.0.1:11222
          [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11222
          [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@334] - STARTING server instance 127.0.0.1:11222
      
          [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x143576544c50000
          [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1
          [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED testDefaultWatcherAutoResetWithChroot
          [junit] junit.framework.AssertionFailedError: expected:<0> but was:<2>
          [junit] 	at junit.framework.Assert.fail(Assert.java:47)
          [junit] 	at junit.framework.Assert.failNotEquals(Assert.java:283)
          [junit] 	at junit.framework.Assert.assertEquals(Assert.java:64)
          [junit] 	at junit.framework.Assert.assertEquals(Assert.java:195)
          [junit] 	at junit.framework.Assert.assertEquals(Assert.java:201)
          [junit] 	at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144)
          [junit] 	at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443)
          [junit] 	at org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123)
          [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      
      1. ZOOKEEPER-1858-br3.4.patch
        12 kB
        Rakesh R
      2. ZOOKEEPER-1858.patch
        11 kB
        Rakesh R
      3. ZOOKEEPER-1858.patch
        7 kB
        Rakesh R
      4. ZOOKEEPER-1858.patch
        7 kB
        Rakesh R
      5. ZOOKEEPER-1858.patch
        7 kB
        Rakesh R
      6. ZOOKEEPER-1858.patch
        8 kB
        Rakesh R
      7. ZOOKEEPER-1858_br3_4.patch
        7 kB
        Rakesh R
      8. ZOOKEEPER-1858_br3_4.patch
        8 kB
        Rakesh R

        Activity

        Hide
        Rakesh R added a comment -

        Attached patch, now while starting the server it will pass the optional beans and will be skipped. These optional beans will not be used for strong assertions.

        Show
        Rakesh R added a comment - Attached patch, now while starting the server it will pass the optional beans and will be skipped. These optional beans will not be used for strong assertions.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12621365/ZOOKEEPER-1858.patch
        against trunk revision 1554981.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 29 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1872//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1872//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1872//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621365/ZOOKEEPER-1858.patch against trunk revision 1554981. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 29 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1872//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1872//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1872//console This message is automatically generated.
        Hide
        angeline shen added a comment -

        2014-01-02 23:53:22,474 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-8cae1bef) Sending network shutdown to VirtualRouter
        2014-01-02 23:53:22,478 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] (Network-Scavenger-1:ctx-8cae1bef) Stopping router VM[DomainRouter|r-8-VM]
        2014-01-02 23:53:22,479 WARN [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-8cae1bef) Unable to complete shutdown of the network elements due to element: VirtualRouter
        java.lang.NullPointerException
        at com.cloud.vm.VirtualMachineManagerImpl.advanceStop(VirtualMachineManagerImpl.java:1268)
        at com.cloud.network.router.VirtualNetworkApplianceManagerImpl.stop(VirtualNetworkApplianceManagerImpl.java:2702)
        at com.cloud.network.router.VirtualNetworkApplianceManagerImpl.stop(VirtualNetworkApplianceManagerImpl.java:139)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:616)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
        at sun.proxy.$Proxy240.stop(Unknown Source)
        at com.cloud.network.element.VirtualRouterElement.shutdown(VirtualRouterElement.java:665)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.shutdownNetworkElementsAndResources(NetworkOrchestrator.java:2052)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.shutdownNetwork(NetworkOrchestrator.java:1965)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$NetworkGarbageCollector.reallyRun(NetworkOrchestrator.java:2305)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$NetworkGarbageCollector.runInContext(NetworkOrchestrator.java:2248)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:165)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:679)
        2014-01-02 23:53:22,488 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-8cae1bef) Lock is released for network Ntwk[205|Guest|8] as a part of network shutdown
        2014-01-02 23:53:23,112 WARN [c.c.u.n.Link] (AgentManager-Selector:null) SSL: Fail to find the generated keystore. Loading fail-safe one to continue.
        2014-01-02 23:53:27,528 DEBUG [c.c.s.StatsCollector] (StatsCollector-2:ctx-0a4e0b12) VmStatsCollector is running...
        2014-01-02 23:53:27,550 DEBUG [c.c.a.m.DirectAgentAttache] (DirectAgent-406:ctx-d13f6f69) Seq 1-77595884: Executing request
        2014-01-02 23:53:27,898 DEBUG [c.c.h.v.m.HostMO] (DirectAgent-406:ctx-d13f6f69 10.223.51.4) find VM i-2-12-VM on host

        2014-01-02 23:13:22,188 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-fbd8a699) Sending network shutdown to VirtualRouter
        2014-01-02 23:13:22,192 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] (Network-Scavenger-1:ctx-fbd8a699) Stopping router VM[DomainRouter|r-8-VM]
        2014-01-02 23:13:22,192 WARN [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-fbd8a699) Unable to complete shutdown of the network elements due to element: VirtualRouter
        java.lang.NullPointerException
        at com.cloud.vm.VirtualMachineManagerImpl.advanceStop(VirtualMachineManagerImpl.java:1268)
        at com.cloud.network.router.VirtualNetworkApplianceManagerImpl.stop(VirtualNetworkApplianceManagerImpl.java:2702)
        at com.cloud.network.router.VirtualNetworkApplianceManagerImpl.stop(VirtualNetworkApplianceManagerImpl.java:139)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:616)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
        at sun.proxy.$Proxy240.stop(Unknown Source)
        at com.cloud.network.element.VirtualRouterElement.shutdown(VirtualRouterElement.java:665)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.shutdownNetworkElementsAndResources(NetworkOrchestrator.java:2052)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.shutdownNetwork(NetworkOrchestrator.java:1965)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$NetworkGarbageCollector.reallyRun(NetworkOrchestrator.java:2305)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$NetworkGarbageCollector.runInContext(NetworkOrchestrator.java:2248)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:165)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:679)
        2014-01-02 23:13:22,202 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-fbd8a699) Lock is released for network Ntwk[205|Guest|8] as a part of network shutdown
        2014-01-02 23:13:23,299 WARN [c.c.u.n.Link] (AgentManager-Selector:null) SSL: Fail to find the generated keystore. Loading fail-safe one to continue.
        2014-01-02 23:13:27,734 DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Handler-4:null) SeqA 3-2432: Processing Seq 3-2432: { Cmd , MgmtId: -1, via: 3, Ver: v1, Flags: 11, [{"com.cloud.agent.api.ConsoleProxyLoadReportC
        ommand":{"_proxyVmId":1,"_loadInfo":"

        {\n \"connections\": []\n}

        ","wait":0}}] }

        Show
        angeline shen added a comment - 2014-01-02 23:53:22,474 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-8cae1bef) Sending network shutdown to VirtualRouter 2014-01-02 23:53:22,478 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] (Network-Scavenger-1:ctx-8cae1bef) Stopping router VM [DomainRouter|r-8-VM] 2014-01-02 23:53:22,479 WARN [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-8cae1bef) Unable to complete shutdown of the network elements due to element: VirtualRouter java.lang.NullPointerException at com.cloud.vm.VirtualMachineManagerImpl.advanceStop(VirtualMachineManagerImpl.java:1268) at com.cloud.network.router.VirtualNetworkApplianceManagerImpl.stop(VirtualNetworkApplianceManagerImpl.java:2702) at com.cloud.network.router.VirtualNetworkApplianceManagerImpl.stop(VirtualNetworkApplianceManagerImpl.java:139) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at sun.proxy.$Proxy240.stop(Unknown Source) at com.cloud.network.element.VirtualRouterElement.shutdown(VirtualRouterElement.java:665) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.shutdownNetworkElementsAndResources(NetworkOrchestrator.java:2052) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.shutdownNetwork(NetworkOrchestrator.java:1965) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$NetworkGarbageCollector.reallyRun(NetworkOrchestrator.java:2305) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$NetworkGarbageCollector.runInContext(NetworkOrchestrator.java:2248) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:679) 2014-01-02 23:53:22,488 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-8cae1bef) Lock is released for network Ntwk [205|Guest|8] as a part of network shutdown 2014-01-02 23:53:23,112 WARN [c.c.u.n.Link] (AgentManager-Selector:null) SSL: Fail to find the generated keystore. Loading fail-safe one to continue. 2014-01-02 23:53:27,528 DEBUG [c.c.s.StatsCollector] (StatsCollector-2:ctx-0a4e0b12) VmStatsCollector is running... 2014-01-02 23:53:27,550 DEBUG [c.c.a.m.DirectAgentAttache] (DirectAgent-406:ctx-d13f6f69) Seq 1-77595884: Executing request 2014-01-02 23:53:27,898 DEBUG [c.c.h.v.m.HostMO] (DirectAgent-406:ctx-d13f6f69 10.223.51.4) find VM i-2-12-VM on host 2014-01-02 23:13:22,188 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-fbd8a699) Sending network shutdown to VirtualRouter 2014-01-02 23:13:22,192 DEBUG [c.c.n.r.VirtualNetworkApplianceManagerImpl] (Network-Scavenger-1:ctx-fbd8a699) Stopping router VM [DomainRouter|r-8-VM] 2014-01-02 23:13:22,192 WARN [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-fbd8a699) Unable to complete shutdown of the network elements due to element: VirtualRouter java.lang.NullPointerException at com.cloud.vm.VirtualMachineManagerImpl.advanceStop(VirtualMachineManagerImpl.java:1268) at com.cloud.network.router.VirtualNetworkApplianceManagerImpl.stop(VirtualNetworkApplianceManagerImpl.java:2702) at com.cloud.network.router.VirtualNetworkApplianceManagerImpl.stop(VirtualNetworkApplianceManagerImpl.java:139) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at sun.proxy.$Proxy240.stop(Unknown Source) at com.cloud.network.element.VirtualRouterElement.shutdown(VirtualRouterElement.java:665) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.shutdownNetworkElementsAndResources(NetworkOrchestrator.java:2052) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.shutdownNetwork(NetworkOrchestrator.java:1965) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$NetworkGarbageCollector.reallyRun(NetworkOrchestrator.java:2305) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$NetworkGarbageCollector.runInContext(NetworkOrchestrator.java:2248) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:679) 2014-01-02 23:13:22,202 DEBUG [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-fbd8a699) Lock is released for network Ntwk [205|Guest|8] as a part of network shutdown 2014-01-02 23:13:23,299 WARN [c.c.u.n.Link] (AgentManager-Selector:null) SSL: Fail to find the generated keystore. Loading fail-safe one to continue. 2014-01-02 23:13:27,734 DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Handler-4:null) SeqA 3-2432: Processing Seq 3-2432: { Cmd , MgmtId: -1, via: 3, Ver: v1, Flags: 11, [{"com.cloud.agent.api.ConsoleProxyLoadReportC ommand":{"_proxyVmId":1,"_loadInfo":" {\n \"connections\": []\n} ","wait":0}}] }
        Hide
        Rakesh R added a comment -

        Hi angeline shen, I didn't understand the stacktrace. Kindly explain the background of the issue and it would be helpful.

        Show
        Rakesh R added a comment - Hi angeline shen , I didn't understand the stacktrace. Kindly explain the background of the issue and it would be helpful.
        Hide
        Rakesh R added a comment -

        I could see CLOUDSTACK-5769 https://issues.apache.org/jira/browse/CLOUDSTACK-5769?focusedCommentId=13861933&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13861933 has the same stacktrace. Also there is no response from @angeline shen about my queries. So I'm strongly thinking, by mistake he might have added the stacktrace to this jira and IMHO we can ignore it.

        Hi All, I would like to know the feedback on the problem statement and the proposed fix. Thanks

        Show
        Rakesh R added a comment - I could see CLOUDSTACK-5769 https://issues.apache.org/jira/browse/CLOUDSTACK-5769?focusedCommentId=13861933&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13861933 has the same stacktrace. Also there is no response from @angeline shen about my queries. So I'm strongly thinking, by mistake he might have added the stacktrace to this jira and IMHO we can ignore it. Hi All, I would like to know the feedback on the problem statement and the proposed fix. Thanks
        Hide
        Germán Blanco added a comment -

        This problem looks very similar to ZOOKEEPER-1837, which was never committed to trunk. The patch in ZOOKEEPER-1837 should work for trunk. Flavio Junqueira, could you please check if it would make sense to apply that fix? Does that cover the issue?

        Show
        Germán Blanco added a comment - This problem looks very similar to ZOOKEEPER-1837 , which was never committed to trunk. The patch in ZOOKEEPER-1837 should work for trunk. Flavio Junqueira , could you please check if it would make sense to apply that fix? Does that cover the issue?
        Hide
        Rakesh R added a comment -

        Yeah German, its similar case only. I'm seeing the issue ZOOKEEPER-1837 has fixed on 14/Dec/13 11:24. Even after the fix I could see again the same case occured in 3.4 branch. Please see the build https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/397/
        I think, good to avoid those client sessions when restarting the server, because timeout may not work well. What do you say?

            [junit] 2014-01-03 09:18:19,710 [myid:] - INFO  [main:FinalRequestProcessor@415] - shutdown of request processor complete
            [junit] 2014-01-03 09:18:19,711 [myid:] - INFO  [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11222
            [junit] 2014-01-03 09:18:20,716 [myid:] - INFO  [main:JMXEnv@135] - ensureOnly:[]
            [junit] 2014-01-03 09:18:20,719 [myid:] - INFO  [main:ZKTestCase$1@65] - FAILED testDefaultWatcherAutoResetWithChroot
            [junit] junit.framework.AssertionFailedError: expected:<0> but was:<2>
            [junit] 	at junit.framework.Assert.fail(Assert.java:47)
            [junit] 	at junit.framework.Assert.failNotEquals(Assert.java:283)
            [junit] 	at junit.framework.Assert.assertEquals(Assert.java:64)
            [junit] 	at junit.framework.Assert.assertEquals(Assert.java:195)
            [junit] 	at junit.framework.Assert.assertEquals(Assert.java:201)
            [junit] 	at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144)
            [junit] 	at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443)
            [junit] 	at org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123)
            [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
            [junit] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            [junit] 	at java.lang.reflect.Method.invoke(Method.java:601)
        
        Show
        Rakesh R added a comment - Yeah German, its similar case only. I'm seeing the issue ZOOKEEPER-1837 has fixed on 14/Dec/13 11:24. Even after the fix I could see again the same case occured in 3.4 branch. Please see the build https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/397/ I think, good to avoid those client sessions when restarting the server, because timeout may not work well. What do you say? [junit] 2014-01-03 09:18:19,710 [myid:] - INFO [main:FinalRequestProcessor@415] - shutdown of request processor complete [junit] 2014-01-03 09:18:19,711 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11222 [junit] 2014-01-03 09:18:20,716 [myid:] - INFO [main:JMXEnv@135] - ensureOnly:[] [junit] 2014-01-03 09:18:20,719 [myid:] - INFO [main:ZKTestCase$1@65] - FAILED testDefaultWatcherAutoResetWithChroot [junit] junit.framework.AssertionFailedError: expected:<0> but was:<2> [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443) [junit] at org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit] at java.lang.reflect.Method.invoke(Method.java:601)
        Hide
        Rakesh R added a comment -

        Adding one more point. Here the failure cause is - due to the immediate zkclient reconnection and publishing of zkclient session beans, while starting back the stopped zkserver.

        Show
        Rakesh R added a comment - Adding one more point. Here the failure cause is - due to the immediate zkclient reconnection and publishing of zkclient session beans, while starting back the stopped zkserver.
        Hide
        Germán Blanco added a comment -

        I think I understand now. I will put it in my own words.
        The problem that you solve here is that there are test cases in which we have running zk clients while a server is stopped and started with ClientBase.stopServer and ClientBase.startServer. ClientBase.startServer has an assertion checking that there are no session beans in JMX, however, depending on timing, the running zk clients might be able to reconnect and create session beans before the check takes place. So we need to have those beans into account in the checking in order to avoid problems.
        ZOOKEEPER-1837 does not solve the problem, since ZOOKEEPER-1837 just repeats this check a few times in order to avoid race conditions in which the JMX update may take longer, but this is actually happening because the correct status in JMX takes less time (with respect to the threads that checks) than what it seems to take in other environments.

        Please correct this interpretation if wrong. Otherwise, +1, it looks good to me.

        Show
        Germán Blanco added a comment - I think I understand now. I will put it in my own words. The problem that you solve here is that there are test cases in which we have running zk clients while a server is stopped and started with ClientBase.stopServer and ClientBase.startServer. ClientBase.startServer has an assertion checking that there are no session beans in JMX, however, depending on timing, the running zk clients might be able to reconnect and create session beans before the check takes place. So we need to have those beans into account in the checking in order to avoid problems. ZOOKEEPER-1837 does not solve the problem, since ZOOKEEPER-1837 just repeats this check a few times in order to avoid race conditions in which the JMX update may take longer, but this is actually happening because the correct status in JMX takes less time (with respect to the threads that checks) than what it seems to take in other environments. Please correct this interpretation if wrong. Otherwise, +1, it looks good to me.
        Hide
        Rakesh R added a comment -

        Yeah German, exactly your thinking is correct

        Show
        Rakesh R added a comment - Yeah German, exactly your thinking is correct
        Hide
        Flavio Junqueira added a comment -

        The assessment of the problem seems ok, but I have a couple of concerns about this patch:

        1. If ensureAll is there, it is likely that someone wanted to make sure we are not leaking JMX beans. Making some names optional defeats the purpose of the check. Here is a guess, though. Is there a way of checking the beans of sessions that do not exist? For a valid session, we ignore the check. A different approach would be to make sure that there are not such sessions. Is any of these possible?
        2. Assuming that this direction is the best we can do, I don't like the changes to the method signatures. Adding optional names to ensureAll is odd because I'd expect something that has all in the name to really check all.
        Show
        Flavio Junqueira added a comment - The assessment of the problem seems ok, but I have a couple of concerns about this patch: If ensureAll is there, it is likely that someone wanted to make sure we are not leaking JMX beans. Making some names optional defeats the purpose of the check. Here is a guess, though. Is there a way of checking the beans of sessions that do not exist? For a valid session, we ignore the check. A different approach would be to make sure that there are not such sessions. Is any of these possible? Assuming that this direction is the best we can do, I don't like the changes to the method signatures. Adding optional names to ensureAll is odd because I'd expect something that has all in the name to really check all.
        Hide
        Rakesh R added a comment -

        Hi Flavio, I agree with you, my previous logic was changing the semantics of ensureAll api.
        Can you please look at the latest patch, where I tried to solve the problem in parent and child beans approach. Does this sound good to you?

        Show
        Rakesh R added a comment - Hi Flavio, I agree with you, my previous logic was changing the semantics of ensureAll api. Can you please look at the latest patch, where I tried to solve the problem in parent and child beans approach. Does this sound good to you?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12622803/ZOOKEEPER-1858.patch
        against trunk revision 1557875.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1883//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622803/ZOOKEEPER-1858.patch against trunk revision 1557875. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1883//console This message is automatically generated.
        Hide
        Rakesh R added a comment -

        Ah. Previously attached patch is from branch3.4. Attaching new patch generated from trunk.

        Show
        Rakesh R added a comment - Ah. Previously attached patch is from branch3.4. Attaching new patch generated from trunk.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12622810/ZOOKEEPER-1858.patch
        against trunk revision 1557875.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1884//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1884//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1884//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622810/ZOOKEEPER-1858.patch against trunk revision 1557875. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1884//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1884//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1884//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        It looks better now, thanks, Rakesh R. I'm still a bit hesitant in checking in this patch as is. Tracing back the change, the JMX stuff apparently got in with ZOOKEEPER-94. I was wondering if Patrick Hunt can chime in to make sure that we are not breaking anything.

        Show
        Flavio Junqueira added a comment - It looks better now, thanks, Rakesh R . I'm still a bit hesitant in checking in this patch as is. Tracing back the change, the JMX stuff apparently got in with ZOOKEEPER-94 . I was wondering if Patrick Hunt can chime in to make sure that we are not breaking anything.
        Hide
        Patrick Hunt added a comment -

        I see why this is necessary, the patch seems reasonable to me.

        One thing caught my eye in the patch

        waits in a loop up to 5 seconds

        why are we waiting 5 seconds?

        Show
        Patrick Hunt added a comment - I see why this is necessary, the patch seems reasonable to me. One thing caught my eye in the patch waits in a loop up to 5 seconds why are we waiting 5 seconds?
        Hide
        Rakesh R added a comment -

        Thanks Flavio Junqueira, Patrick Hunt for the reviews.

        why are we waiting 5 seconds?

        Please see ZOOKEEPER-1837 issue. There is a pattern we had observed while analysing the windows jenkins failure, it may take few moments to see the published beans by the clients and the test cases are failing randomly due to this. So its giving some more grace period rather than failing immediately.

        Show
        Rakesh R added a comment - Thanks Flavio Junqueira , Patrick Hunt for the reviews. why are we waiting 5 seconds? Please see ZOOKEEPER-1837 issue. There is a pattern we had observed while analysing the windows jenkins failure, it may take few moments to see the published beans by the clients and the test cases are failing randomly due to this. So its giving some more grace period rather than failing immediately.
        Hide
        Patrick Hunt added a comment -

        The reason I ask, 5 seconds is pretty short. What typically ends up happening is that it works fine for you, but on lesser powered (underprovisioned) test hardware it will fail. We end up with a flakey test. What I'd suggest is either don't use a timeout, or, if you do need to use a timeout use something crazy large (60 sec?), typically including polling at a shorter interval. The key is that the test, in the typical case, should not be affected by the 60sec timeout (it should not take 60 sec longer for example) but if the h/w is slow we can handle that case and still give the test a chance to pass.

        Show
        Patrick Hunt added a comment - The reason I ask, 5 seconds is pretty short. What typically ends up happening is that it works fine for you, but on lesser powered (underprovisioned) test hardware it will fail. We end up with a flakey test. What I'd suggest is either don't use a timeout, or, if you do need to use a timeout use something crazy large (60 sec?), typically including polling at a shorter interval. The key is that the test, in the typical case, should not be affected by the 60sec timeout (it should not take 60 sec longer for example) but if the h/w is slow we can handle that case and still give the test a chance to pass.
        Hide
        Rakesh R added a comment -

        Thanks Patrick Hunt, attached patch by giving 60secs grace period.

        Show
        Rakesh R added a comment - Thanks Patrick Hunt , attached patch by giving 60secs grace period.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623353/ZOOKEEPER-1858.patch
        against trunk revision 1557875.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1890//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1890//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1890//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623353/ZOOKEEPER-1858.patch against trunk revision 1557875. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1890//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1890//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1890//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        Thanks for checking this one out, @phunt. Rakesh R, will you generate a 3.4 patch?

        Show
        Flavio Junqueira added a comment - Thanks for checking this one out, @phunt. Rakesh R , will you generate a 3.4 patch?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623411/ZOOKEEPER-1858_br3_4.patch
        against trunk revision 1557875.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1891//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623411/ZOOKEEPER-1858_br3_4.patch against trunk revision 1557875. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1891//console This message is automatically generated.
        Hide
        Rakesh R added a comment -

        Hi Flavio, attached 3.4 patch. Please have a look at it.

        As this is 3.4 patch, please ignore jenkins failure report (if any)

        Show
        Rakesh R added a comment - Hi Flavio, attached 3.4 patch. Please have a look at it. As this is 3.4 patch, please ignore jenkins failure report (if any)
        Hide
        Flavio Junqueira added a comment -

        The 3.4 patch looks good, but the trunk patch conflicts. Could you fix it, please, Rakesh R?

        Show
        Flavio Junqueira added a comment - The 3.4 patch looks good, but the trunk patch conflicts. Could you fix it, please, Rakesh R ?
        Hide
        Rakesh R added a comment -

        Hi Flavio, I have rebased both trunk and branch3.4 patch.
        In this I have added link to the JIRA also, please have a look at it.

        Show
        Rakesh R added a comment - Hi Flavio, I have rebased both trunk and branch3.4 patch. In this I have added link to the JIRA also, please have a look at it.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623957/ZOOKEEPER-1858.patch
        against trunk revision 1558950.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1895//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1895//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1895//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623957/ZOOKEEPER-1858.patch against trunk revision 1558950. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1895//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1895//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1895//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        +1, thanks Rakesh R.

        Trunk: Committed revision 1561236.
        Branch 3.4: Committed revision 1561069

        Show
        Flavio Junqueira added a comment - +1, thanks Rakesh R . Trunk: Committed revision 1561236. Branch 3.4: Committed revision 1561069
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in ZooKeeper-trunk #2195 (See https://builds.apache.org/job/ZooKeeper-trunk/2195/)
        ZOOKEEPER-1858. JMX checks - potential race conditions while stopping
        and starting server (Rakesh R via fpj) (fpj: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1561236)

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientBase.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/JMXEnv.java
        Show
        Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2195 (See https://builds.apache.org/job/ZooKeeper-trunk/2195/ ) ZOOKEEPER-1858 . JMX checks - potential race conditions while stopping and starting server (Rakesh R via fpj) (fpj: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1561236 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientBase.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/JMXEnv.java
        Hide
        Flavio Junqueira added a comment -

        Closing issues after releasing 3.4.6.

        Show
        Flavio Junqueira added a comment - Closing issues after releasing 3.4.6.

          People

          • Assignee:
            Rakesh R
            Reporter:
            Rakesh R
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development