ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1833 fix windows build
  3. ZOOKEEPER-1858

JMX checks - potential race conditions while stopping and starting server

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.6, 3.5.0
    • Component/s: None
    • Labels:

      Description

      I've noticed one potential case, where previously created zkclient session immediately reconnected and publishing those beans while starting back the zkserver and affecting zk#startup jmx checks.

      Say, before stopping the server, there is a zk client session 0x143576544c50000 exists. While starting back the server, there could be possibility of seeing the client sessions in jmx. Following is one such case. Please see below logs which has taken from build https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/642/

          [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1228] - Session establishment complete on server 127.0.0.1/127.0.0.1:11222, sessionid = 0x143576544c50000, negotiated timeout = 30000
          [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11222:ZooKeeperServer@617] - Established session 0x143576544c50000 with negotiated timeout 30000 for client /127.0.0.1:55377
       [junit] 2014-01-03 09:18:12,391 [myid:] - INFO  [main:JMXEnv@135] - ensureOnly:[]
          [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@438] - STARTING server
          [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@359] - CREATING server instance 127.0.0.1:11222
          [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11222
          [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@334] - STARTING server instance 127.0.0.1:11222
      
          [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x143576544c50000
          [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1
          [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED testDefaultWatcherAutoResetWithChroot
          [junit] junit.framework.AssertionFailedError: expected:<0> but was:<2>
          [junit] 	at junit.framework.Assert.fail(Assert.java:47)
          [junit] 	at junit.framework.Assert.failNotEquals(Assert.java:283)
          [junit] 	at junit.framework.Assert.assertEquals(Assert.java:64)
          [junit] 	at junit.framework.Assert.assertEquals(Assert.java:195)
          [junit] 	at junit.framework.Assert.assertEquals(Assert.java:201)
          [junit] 	at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144)
          [junit] 	at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443)
          [junit] 	at org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123)
          [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      
      1. ZOOKEEPER-1858_br3_4.patch
        8 kB
        Rakesh R
      2. ZOOKEEPER-1858_br3_4.patch
        7 kB
        Rakesh R
      3. ZOOKEEPER-1858.patch
        8 kB
        Rakesh R
      4. ZOOKEEPER-1858.patch
        7 kB
        Rakesh R
      5. ZOOKEEPER-1858.patch
        7 kB
        Rakesh R
      6. ZOOKEEPER-1858.patch
        7 kB
        Rakesh R
      7. ZOOKEEPER-1858.patch
        11 kB
        Rakesh R
      8. ZOOKEEPER-1858-br3.4.patch
        12 kB
        Rakesh R

        Activity

        Rakesh R created issue -
        Rakesh R made changes -
        Field Original Value New Value
        Fix Version/s 3.4.6 [ 12323310 ]
        Rakesh R made changes -
        Fix Version/s 3.5.0 [ 12316644 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1858-br3.4.patch [ 12621364 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1858.patch [ 12621365 ]
        Rakesh R made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Rakesh R made changes -
        Labels test
        Flavio Junqueira made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1858.patch [ 12622803 ]
        Rakesh R made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1858.patch [ 12622810 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1858.patch [ 12623353 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1858_br3_4.patch [ 12623411 ]
        Flavio Junqueira made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1858_br3_4.patch [ 12623956 ]
        Rakesh R made changes -
        Attachment ZOOKEEPER-1858.patch [ 12623957 ]
        Rakesh R made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Flavio Junqueira made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Flavio Junqueira made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Rakesh R
            Reporter:
            Rakesh R
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development