ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-184

tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: c client
    • Labels:
      None
    • Environment:

      Linux

    • Hadoop Flags:
      Reviewed

      Description

      Some compilation environments provide implicit inclusion of certain system headers.
      But any way it's not a reason to exploit it in platform-independent projects.

      TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers.

      Modern versions of GCC are very strict.
      You cannot build the code like this with the help of GCC version 4.3.

      1. ZOOKEEPER-184.patch
        0.7 kB
        Maxim P. Dementiev

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 7h 51m 1 Maxim P. Dementiev 14/Oct/08 19:44
        Patch Available Patch Available Resolved Resolved
        45m 18s 1 Patrick Hunt 14/Oct/08 20:29
        Resolved Resolved Closed Closed
        11d 4h 41m 1 Patrick Hunt 26/Oct/08 01:10
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Patrick Hunt added a comment -

        3.0.0 has been released, closing issues.

        Show
        Patrick Hunt added a comment - 3.0.0 has been released, closing issues.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #114 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/114/)
        . tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions — also addressed some missing jiras from CHANGES.txt

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #114 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/114/ ) . tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions — also addressed some missing jiras from CHANGES.txt
        Patrick Hunt made changes -
        Resolution Fixed [ 1 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 3.0.0 [ 12313216 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hide
        Patrick Hunt added a comment -

        Committed revision 704667.

        Show
        Patrick Hunt added a comment - Committed revision 704667.
        Maxim P. Dementiev made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Patrick Hunt made changes -
        Assignee Maxim P. Dementiev [ dememax ]
        Maxim P. Dementiev made changes -
        Description Some compilation environments provide implicit inclusion of certain system headers.
        But any way it's not a reason to exploit it in platform-independent projects.

        TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers.
        Some compilation environments provide implicit inclusion of certain system headers.
        But any way it's not a reason to exploit it in platform-independent projects.

        TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers.

        Modern versions of GCC are very strict.
        You cannot build the code like this with the help of GCC version 4.3.
        Maxim P. Dementiev made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-184.patch [ 12392006 ]
        Hide
        Maxim P. Dementiev added a comment -

        The patch is obvious: include corresponding system header.

        Show
        Maxim P. Dementiev added a comment - The patch is obvious: include corresponding system header.
        Maxim P. Dementiev created issue -

          People

          • Assignee:
            Maxim P. Dementiev
            Reporter:
            Maxim P. Dementiev
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development