Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-184

tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: c client
    • Labels:
      None
    • Environment:

      Linux

    • Hadoop Flags:
      Reviewed

      Description

      Some compilation environments provide implicit inclusion of certain system headers.
      But any way it's not a reason to exploit it in platform-independent projects.

      TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers.

      Modern versions of GCC are very strict.
      You cannot build the code like this with the help of GCC version 4.3.

      1. ZOOKEEPER-184.patch
        0.7 kB
        Maxim P. Dementiev

        Activity

        Hide
        dememax Maxim P. Dementiev added a comment -

        The patch is obvious: include corresponding system header.

        Show
        dememax Maxim P. Dementiev added a comment - The patch is obvious: include corresponding system header.
        Hide
        phunt Patrick Hunt added a comment -

        Committed revision 704667.

        Show
        phunt Patrick Hunt added a comment - Committed revision 704667.
        Hide
        hudson Hudson added a comment -

        Integrated in ZooKeeper-trunk #114 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/114/)
        . tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions — also addressed some missing jiras from CHANGES.txt

        Show
        hudson Hudson added a comment - Integrated in ZooKeeper-trunk #114 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/114/ ) . tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions — also addressed some missing jiras from CHANGES.txt
        Hide
        phunt Patrick Hunt added a comment -

        3.0.0 has been released, closing issues.

        Show
        phunt Patrick Hunt added a comment - 3.0.0 has been released, closing issues.

          People

          • Assignee:
            dememax Maxim P. Dementiev
            Reporter:
            dememax Maxim P. Dementiev
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development