ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-184

tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: c client
    • Labels:
      None
    • Environment:

      Linux

    • Hadoop Flags:
      Reviewed

      Description

      Some compilation environments provide implicit inclusion of certain system headers.
      But any way it's not a reason to exploit it in platform-independent projects.

      TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers.

      Modern versions of GCC are very strict.
      You cannot build the code like this with the help of GCC version 4.3.

      1. ZOOKEEPER-184.patch
        0.7 kB
        Maxim P. Dementiev

        Activity

        Maxim P. Dementiev created issue -
        Maxim P. Dementiev made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-184.patch [ 12392006 ]
        Maxim P. Dementiev made changes -
        Description Some compilation environments provide implicit inclusion of certain system headers.
        But any way it's not a reason to exploit it in platform-independent projects.

        TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers.
        Some compilation environments provide implicit inclusion of certain system headers.
        But any way it's not a reason to exploit it in platform-independent projects.

        TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers.

        Modern versions of GCC are very strict.
        You cannot build the code like this with the help of GCC version 4.3.
        Patrick Hunt made changes -
        Assignee Maxim P. Dementiev [ dememax ]
        Maxim P. Dementiev made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Patrick Hunt made changes -
        Resolution Fixed [ 1 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 3.0.0 [ 12313216 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Patrick Hunt made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Maxim P. Dementiev
            Reporter:
            Maxim P. Dementiev
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development