Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-184

tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0
    • c client
    • None
    • Linux

    • Reviewed

    Description

      Some compilation environments provide implicit inclusion of certain system headers.
      But any way it's not a reason to exploit it in platform-independent projects.

      TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers.

      Modern versions of GCC are very strict.
      You cannot build the code like this with the help of GCC version 4.3.

      Attachments

        1. ZOOKEEPER-184.patch
          0.7 kB
          Maxim P. Dementiev

        Activity

          People

            dememax Maxim P. Dementiev
            dememax Maxim P. Dementiev
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: