[ZOOKEEPER-1837] Fix JMXEnv checks (potential race conditions)

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.5, 3.5.0
• Fix Version/s: 3.4.6, 3.5.0
• Component/s: tests

Environment

Windows 8

• Assignee: Germán Blanco Assign to me
• Reporter: Germán Blanco
• Created: 13/Dec/13 07:40
• Updated: 13/Mar/14 18:16
• Resolved: 16/Jan/14 23:01

Description

The following failures in ZooKeeper-3.4-WinVS2008_java and ZooKeeper-trunk-WinVS2008_java require fixing:
[junit] junit.framework.AssertionFailedError: expected:<0> but was:<1>
[junit] at junit.framework.Assert.fail(Assert.java:47)
[junit] at junit.framework.Assert.failNotEquals(Assert.java:283)
[junit] at junit.framework.Assert.assertEquals(Assert.java:64)
[junit] at junit.framework.Assert.assertEquals(Assert.java:195)
[junit] at junit.framework.Assert.assertEquals(Assert.java:201)
[junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
[junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
[junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[junit] at java.lang.reflect.Method.invoke(Method.java:597)
[junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
[junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
[junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
[junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)

[junit] junit.framework.AssertionFailedError: expected:<0> but was:<1>
[junit] at junit.framework.Assert.fail(Assert.java:47)
[junit] at junit.framework.Assert.failNotEquals(Assert.java:283)
[junit] at junit.framework.Assert.assertEquals(Assert.java:64)
[junit] at junit.framework.Assert.assertEquals(Assert.java:195)
[junit] at junit.framework.Assert.assertEquals(Assert.java:201)
[junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
[junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
[junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[junit] at java.lang.reflect.Method.invoke(Method.java:597)
[junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
[junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
[junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
[junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
[junit] at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
[

junit.framework.AssertionFailedError: expected [0x142e5f027b50001] expected:<1> but was:<0>
at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115)
at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197)
at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171)
at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156)
at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149)
at org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45)
at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)