[ZOOKEEPER-1766] Consistent log severity level guards and statements

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.5
• Fix Version/s: 3.5.0
• Assignee: Jackie Chang
• Reporter: Jackie Chang
• Created: 26/Sep/13 04:25
• Updated: 12/Feb/15 09:51
• Resolved: 04/Oct/13 22:22

Description

A log statement should be guarded by its matching severity level. A log statement like

if (LOG.isTraceEnabled()) {
LOG.info("Session closing: 0x" + Long.toHexString(sessionId));

doesn't make much sense because the log message is only printed out when TRACE-level is enabled. This inconsistency was possibly introduced when developers demoted the original log statement from INFO but forgot to change its corresponding log severity level.