[ZOOKEEPER-1719] zkCli.sh, zkServer.sh and zkEnv.sh regression caused by ZOOKEEPER-1663

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.5, 3.5.0
• Fix Version/s: 3.4.6, 3.5.0

Environment

Linux (Ubuntu 12.04) with dash shell

• Assignee: Marshall McMullen
• Reporter: Marshall McMullen
• Created: 25/Jun/13 18:00
• Updated: 25/Jul/14 11:25
• Resolved: 28/Jun/13 16:28

Description

This fix from ZOOKEEPER-1663 is incorrect. It assumes the shell is bash since it uses bash array construction, e.g.:

 96   LIBPATH=("${ZOOKEEPER_PREFIX}"/share/zookeeper/*.jar)

This does NOT work if /bin/sh points to /bin/dash as it does on Ubuntu.

It fails as so:

zkEnv.sh: 96: zkEnv.sh: Syntax error: "(" unexpected (expecting "fi")

If I change the shebang at the top to use "/bin/bash" instead of "/bin/sh" it works as expected. I don't know the full details of why using a bash array was chosen as the solution but I don't think it is the right way to deal with spaces in these paths...