[ZOOKEEPER-1684] Failure to update socket addresses on immedate connection

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Shevek
• Created: 05/Apr/13 20:43
• Updated: 03/Feb/22 08:50

Description

I quote:

void registerAndConnect(SocketChannel sock, InetSocketAddress addr)
throws IOException

{ sockKey = sock.register(selector, SelectionKey.OP_CONNECT); boolean immediateConnect = sock.connect(addr); if (immediateConnect) { sendThread.primeConnection(); }

}

In the immediate case, there are several bugs:

a) updateSocketAddresses() is never called, as it is when the select-loop in doTransport(). This means that clientCnxnSocket.getRemoteSocketAddress() will return null for the lifetime of this socket?
b) CONNECT still in the interest set for the socket.
c) updateLastSendAndHeard() is never called either.

Issue Links

• is related to: ZOOKEEPER-1683 ZooKeeper client NPE when updating server list on disconnected client
• is related to: CURATOR-7 Session ids not preserved if EnsembleProvider has changed the ensemble