ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1572

Add an async interface for multi request

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.5
    • Fix Version/s: 3.5.0
    • Component/s: java client
    • Labels:

      Description

      Currently there is no async interface for multi request in ZooKeeper java client.

      1. ZOOKEEPER-1572.diff
        23 kB
        Sijie Guo
      2. ZOOKEEPER-1572.diff
        23 kB
        Sijie Guo
      3. ZOOKEEPER-1572.patch
        22 kB
        Camille Fournier

        Issue Links

        There are no Sub-Tasks for this issue.

          Activity

          Hide
          Sijie Guo added a comment -

          Attach a patch to add an async interface for multi request in ZooKeeper java client.

          Show
          Sijie Guo added a comment - Attach a patch to add an async interface for multi request in ZooKeeper java client.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12551684/ZOOKEEPER-1572.diff
          against trunk revision 1404288.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 3 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1244//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1244//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1244//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12551684/ZOOKEEPER-1572.diff against trunk revision 1404288. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 3 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1244//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1244//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1244//console This message is automatically generated.
          Hide
          Sijie Guo added a comment -

          upload a new patch to address javadoc warning.

          Show
          Sijie Guo added a comment - upload a new patch to address javadoc warning.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12552254/ZOOKEEPER-1572.diff
          against trunk revision 1404288.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1249//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1249//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1249//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552254/ZOOKEEPER-1572.diff against trunk revision 1404288. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1249//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1249//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1249//console This message is automatically generated.
          Hide
          Flavio Junqueira added a comment -

          +1, this patch is good for me. It would be good if one of the multi gurus could also have a look at the patch. If I don't hear anything in the next 48 hours, I'll commit it.

          Show
          Flavio Junqueira added a comment - +1, this patch is good for me. It would be good if one of the multi gurus could also have a look at the patch. If I don't hear anything in the next 48 hours, I'll commit it.
          Hide
          Marshall McMullen added a comment -

          I looked over this patch as well, and from a multi perspective everything looks correct. I confess I don't know much about the async API on the Java client side so I didn't focus on those details. But the multi stuff looks correct.

          Show
          Marshall McMullen added a comment - I looked over this patch as well, and from a multi perspective everything looks correct. I confess I don't know much about the async API on the Java client side so I didn't focus on those details. But the multi stuff looks correct.
          Hide
          Mahadev konar added a comment -

          Removing it from 3.4 branch. We shouldnt commit new features in 3.4 branch.

          Show
          Mahadev konar added a comment - Removing it from 3.4 branch. We shouldnt commit new features in 3.4 branch.
          Hide
          Mahadev konar added a comment -

          Flavio/Sejie,
          I am taking a look at this. Might need a day or 2 (maximum until tuesday) to review this.

          Show
          Mahadev konar added a comment - Flavio/Sejie, I am taking a look at this. Might need a day or 2 (maximum until tuesday) to review this.
          Hide
          Thawan Kooburat added a comment -

          Anything is blocking this patch? We just found a bug in multi-op, it will be simpler to write a unit test if we have this

          Show
          Thawan Kooburat added a comment - Anything is blocking this patch? We just found a bug in multi-op, it will be simpler to write a unit test if we have this
          Hide
          Mahadev konar added a comment -

          The patch looks good to me. Will go ahead and commit after running through hudson.

          Show
          Mahadev konar added a comment - The patch looks good to me. Will go ahead and commit after running through hudson.
          Hide
          Camille Fournier added a comment -

          Uploading a patch that applies cleanly to trunk

          Show
          Camille Fournier added a comment - Uploading a patch that applies cleanly to trunk
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12567658/ZOOKEEPER-1572.patch
          against trunk revision 1438375.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings).

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1376//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1376//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1376//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1376//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567658/ZOOKEEPER-1572.patch against trunk revision 1438375. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1376//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1376//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1376//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1376//console This message is automatically generated.
          Hide
          Camille Fournier added a comment -

          Anyone know why these release audit warnings have started triggering? Looks like they're triggering for every patch now.

          Show
          Camille Fournier added a comment - Anyone know why these release audit warnings have started triggering? Looks like they're triggering for every patch now.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12567658/ZOOKEEPER-1572.patch
          against trunk revision 1441860.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1377//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1377//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1377//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567658/ZOOKEEPER-1572.patch against trunk revision 1441860. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1377//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1377//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1377//console This message is automatically generated.
          Hide
          Camille Fournier added a comment -

          This looks good, checking it in.

          Show
          Camille Fournier added a comment - This looks good, checking it in.
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1823 (See https://builds.apache.org/job/ZooKeeper-trunk/1823/)
          ZOOKEEPER-1572. Add an async (Java) interface for multi request (Sijie Guo via camille) (Revision 1441922)

          Result = SUCCESS
          camille : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441922
          Files :

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/AsyncCallback.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/Transaction.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1823 (See https://builds.apache.org/job/ZooKeeper-trunk/1823/ ) ZOOKEEPER-1572 . Add an async (Java) interface for multi request (Sijie Guo via camille) (Revision 1441922) Result = SUCCESS camille : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441922 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/AsyncCallback.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/Transaction.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java
          Hide
          Ivan Kelly added a comment -

          This would be good to have on the 3.4 branch since 3.5 is going to take some time to stablize. Any objections to me backporting the patch?

          Show
          Ivan Kelly added a comment - This would be good to have on the 3.4 branch since 3.5 is going to take some time to stablize. Any objections to me backporting the patch?
          Hide
          Rakesh R added a comment -

          +1 from me.
          As multi feature already available in 3.4.x version, can backport async version of multi in 3.4 branch.

          Show
          Rakesh R added a comment - +1 from me. As multi feature already available in 3.4.x version , can backport async version of multi in 3.4 branch .

            People

            • Assignee:
              Sijie Guo
              Reporter:
              Sijie Guo
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development