[ZOOKEEPER-1493] C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.3, 3.3.5
• Fix Version/s: 3.3.6, 3.4.4, 3.5.0
• Component/s: c client
• Hadoop Flags: Reviewed
• Assignee: Michi Mutsuzaki
• Reporter: Michi Mutsuzaki
• Created: 20/Jun/12 20:47
• Updated: 21/Nov/12 10:12
• Resolved: 29/Jul/12 05:35

Description

In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.