ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1493

C Client: zookeeper_process doesn't invoke completion callback if zookeeper_close has been called

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.3, 3.3.5
    • Fix Version/s: 3.3.6, 3.4.4, 3.5.0
    • Component/s: c client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In ZOOKEEPER-804, we added a check in zookeeper_process() to see if zookeeper_close() has been called. This was to avoid calling assert(cptr) on a NULL pointer, as dequeue_completion() returns NULL if the sent_requests queue has been cleared by free_completion() from zookeeper_close(). However, we should still call the completion if it is not NULL.

      1. ZOOKEEPER-1493_3_4.patch
        0.8 kB
        Michi Mutsuzaki
      2. ZOOKEEPER-1493_3_3.patch
        0.8 kB
        Michi Mutsuzaki
      3. ZOOKEEPER-1493.patch
        0.8 kB
        Michi Mutsuzaki

        Activity

        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Michi Mutsuzaki made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1493_3_3.patch [ 12534134 ]
        Attachment ZOOKEEPER-1493_3_4.patch [ 12534135 ]
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Michi Mutsuzaki made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Michi Mutsuzaki made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Michi Mutsuzaki made changes -
        Attachment ZOOKEEPER-1493.patch [ 12532779 ]
        Michi Mutsuzaki made changes -
        Field Original Value New Value
        Assignee Michi Mutsuzaki [ michim ]
        Michi Mutsuzaki created issue -

          People

          • Assignee:
            Michi Mutsuzaki
            Reporter:
            Michi Mutsuzaki
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development