ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1483

Fix leader election recipe documentation

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.3
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: documentation
    • Labels:
      None

      Description

      The leader election recipe documentation suggest that to avoid the herd effect a client process volunteering for leadership via child znode [i] under the leader election path [/leader] must only watch the the SMALLEST znode [j] from a different client process such that [j < i].

      This will NOT avoid the herd effect as many clients will end up watching the same znode[j] where j is the next-in-sequence number greater than the number of the current leader.

      Specifically in Step 3 of the Election procedure here http://zookeeper.apache.org/doc/trunk/recipes.html#sc_leaderElection

      This "where j is the SMALLEST sequence number" should be changed to this
      "where j is the LARGEST sequence number"

      1. ZOOKEEPER-1483-3.4.patch
        1 kB
        Michi Mutsuzaki
      2. ZOOKEEPER-1483-trunk.patch
        1 kB
        Michi Mutsuzaki

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1679 (See https://builds.apache.org/job/ZooKeeper-trunk/1679/)
          ZOOKEEPER-1483. Fix leader election recipe documentation (Michi Mutsuzaki via mahadev) (Revision 1384669)

          Result = SUCCESS
          mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384669
          Files :

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/src/docs/src/documentation/content/xdocs/recipes.xml
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1679 (See https://builds.apache.org/job/ZooKeeper-trunk/1679/ ) ZOOKEEPER-1483 . Fix leader election recipe documentation (Michi Mutsuzaki via mahadev) (Revision 1384669) Result = SUCCESS mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384669 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/docs/src/documentation/content/xdocs/recipes.xml
          Hide
          Mahadev konar added a comment -

          Thanks Michi. Just committed this to both 3.4 and trunk.

          Show
          Mahadev konar added a comment - Thanks Michi. Just committed this to both 3.4 and trunk.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12544576/ZOOKEEPER-1483-trunk.patch
          against trunk revision 1382661.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1182//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1182//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1182//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544576/ZOOKEEPER-1483-trunk.patch against trunk revision 1382661. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1182//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1182//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1182//console This message is automatically generated.
          Hide
          Michi Mutsuzaki added a comment -

          Created patches for trunk and 3.4 branch. In addition to the recipe error, These patches fix a grammatical error.

          Show
          Michi Mutsuzaki added a comment - Created patches for trunk and 3.4 branch. In addition to the recipe error, These patches fix a grammatical error.

            People

            • Assignee:
              Michi Mutsuzaki
              Reporter:
              Ankur
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development