Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1478

Small bug in QuorumTest.testFollowersStartAfterLeader( )

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.4.3
    • 3.4.6, 3.5.0
    • tests
    • None
    • Reviewed

    Description

      The following code appears in QuorumTest.testFollowersStartAfterLeader( ):

      for (int i = 0; i < 30; i++) {
      try

      { zk.create("/test", "test".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT); break; }

      catch(KeeperException.ConnectionLossException e)

      { Thread.sleep(1000); }

      // test fails if we still can't connect to the quorum after 30 seconds.
      Assert.fail("client could not connect to reestablished quorum: giving up after 30+ seconds.");
      }

      From the comment it looks like the intention was to try to reconnect 30 times and only then trigger the Assert, but that's not what this does.
      After we fail to connect once and Thread.sleep is executed, Assert.fail will be executed without retrying create.

      Attachments

        1. ZOOKEEPER-1478.patch
          2 kB
          Mahadev Konar
        2. ZOOKEEPER-1478.patch
          2 kB
          Alexander Shraer
        3. ZOOKEEPER-1478.patch
          2 kB
          Flavio Paiva Junqueira
        4. ZOOKEEPER-1478.patch
          1 kB
          Flavio Paiva Junqueira
        5. ZOOKEEPER-1478.patch
          1 kB
          Alexander Shraer

        Activity

          People

            shralex Alexander Shraer
            shralex Alexander Shraer
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: