[ZOOKEEPER-1478] Small bug in QuorumTest.testFollowersStartAfterLeader( )

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.3
• Fix Version/s: 3.4.6, 3.5.0
• Component/s: tests
• Hadoop Flags: Reviewed
• Assignee: Alexander Shraer
• Reporter: Alexander Shraer
• Created: 03/Jun/12 03:03
• Updated: 13/Mar/14 18:16
• Resolved: 13/Dec/12 07:19

Description

The following code appears in QuorumTest.testFollowersStartAfterLeader( ):

for (int i = 0; i < 30; i++) {
try

{ zk.create("/test", "test".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT); break; }

catch(KeeperException.ConnectionLossException e)

{ Thread.sleep(1000); }

// test fails if we still can't connect to the quorum after 30 seconds.
Assert.fail("client could not connect to reestablished quorum: giving up after 30+ seconds.");
}

From the comment it looks like the intention was to try to reconnect 30 times and only then trigger the Assert, but that's not what this does.
After we fail to connect once and Thread.sleep is executed, Assert.fail will be executed without retrying create.