Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.3
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: jute
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are 2 issues with the current jute generated C++ code.

      1. Variable declaration for JRecord is incorrect. It looks something like this:

       
          Id id;
      

      It should be like this instead:

       
       org::apache::zookeeper::data::Id mid;
      

      2. The header file declares all the variables (except for JRecord ones) with "m" prefix, but the .cc file doesn't use the prefix.

      1. ZOOKEEPER-1471.patch
        3 kB
        Michi Mutsuzaki

        Activity

        Hide
        Michi Mutsuzaki added a comment -

        I didn't include a test for this since the existing jute code doesn't have a test either. I generated C++ code with the modified version of jute and verified it fixed all the compilation errors.

        --Michi

        Show
        Michi Mutsuzaki added a comment - I didn't include a test for this since the existing jute code doesn't have a test either. I generated C++ code with the modified version of jute and verified it fixed all the compilation errors. --Michi
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12528368/ZOOKEEPER-1471.patch
        against trunk revision 1337029.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1083//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1083//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1083//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528368/ZOOKEEPER-1471.patch against trunk revision 1337029. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1083//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1083//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1083//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Thanks Michi!

        Show
        Patrick Hunt added a comment - Thanks Michi!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1600 (See https://builds.apache.org/job/ZooKeeper-trunk/1600/)
        ZOOKEEPER-1471. Jute generates invalid C++ code (Michi Mutsuzaki via phunt) (Revision 1355653)

        Result = SUCCESS
        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355653
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/main/org/apache/jute/compiler/JRecord.java
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1600 (See https://builds.apache.org/job/ZooKeeper-trunk/1600/ ) ZOOKEEPER-1471 . Jute generates invalid C++ code (Michi Mutsuzaki via phunt) (Revision 1355653) Result = SUCCESS phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355653 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/jute/compiler/JRecord.java

          People

          • Assignee:
            Michi Mutsuzaki
            Reporter:
            Michi Mutsuzaki
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development