ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1833 fix windows build
  3. ZOOKEEPER-1459

Standalone ZooKeeperServer is not closing the transaction log files on shutdown

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.0
    • Fix Version/s: 3.4.6, 3.5.0
    • Component/s: server
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change

      Description

      When shutdown the standalone ZK server, its only clearing the zkdatabase and not closing the transaction log streams. When tries to delete the temporary files in unit tests on windows, its failing.
      ZooKeeperServer.java

              if (zkDb != null) {
                  zkDb.clear();
              }
      

      Suggestion to close the zkDb as follows, this inturn will take care transaction logs:

              if (zkDb != null) {
                  zkDb.clear();
                  try {
                      zkDb.close();
                  } catch (IOException ie) {
                      LOG.warn("Error closing logs ", ie);
                  }
              }
      
      1. ZOOKEEPER-1459-branch-3_4.patch
        4 kB
        Rakesh R
      2. ZOOKEEPER-1459-branch-3_4.patch
        3 kB
        Rakesh R
      3. ZOOKEEPER-1459.patch
        0.6 kB
        Rakesh R
      4. ZOOKEEPER-1459.patch
        1 kB
        Rakesh R
      5. ZOOKEEPER-1459.patch
        1 kB
        Rakesh R
      6. ZOOKEEPER-1459.patch
        4 kB
        Rakesh R
      7. ZOOKEEPER-1459.patch
        1 kB
        David Lao
      8. ZOOKEEPER-1459.patch
        4 kB
        David Lao
      9. ZOOKEEPER-1459.patch
        4 kB
        Rakesh R
      10. ZOOKEEPER-1459.patch
        3 kB
        Rakesh R

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Rakesh R
            Reporter:
            Rakesh R
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development