ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1454

Document how to run autoreconf if cppunit is installed in a non-standard directory

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.6, 3.4.4, 3.5.0
    • Component/s: c client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      By default, the source distribution of cppunit is installed under /usr/local. When you run autoreconf -if, you get an error like this:

      $ autoreconf -if
      configure.ac:37: warning: macro `AM_PATH_CPPUNIT' not found in library
      configure.ac:37: warning: macro `AM_PATH_CPPUNIT' not found in library
      configure.ac:37: error: possibly undefined macro: AM_PATH_CPPUNIT
            If this token and others are legitimate, please use m4_pattern_allow.
            See the Autoconf documentation.
      autoreconf: /usr/local/bin/autoconf failed with exit status: 1
      

      This is because cppunit.m4 is installed under /usr/local/share/aclocal, but aclocal only looks at /usr/share/aclocal-$VERSION and /usr/share/aclocal assuming it was configured with --prefix=/usr. There are 3 ways to specify additional paths.

      1. Set ACLOCAL.

      ACLOCAL="aclocal -I /usr/local/share/aclocal" autoreconf -if 
      

      2. Set ACLOCAL_PATH.

      ACLOCAL_PATH=/usr/local/share/aclocal autoreconf -if
      

      3. Set ACLOCAL_FLAGS.

      ACLOCAL_FLAGS="-I /usr/local/share/aclocal" autoreconf -if
      

      Apparently older versions of autoreconf don't respect ACLOCAL_PATH or ACLOCAL_FLAGS, so using ACLOCAL is probably the best way to fix it. I'll update src/c/README to document this.

      --Michi

      1. ZOOKEEPER-1454.patch
        0.9 kB
        Michi Mutsuzaki

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524354/ZOOKEEPER-1454.patch
        against trunk revision 1330043.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524354/ZOOKEEPER-1454.patch against trunk revision 1330043. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1049//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

        No code change.

        --Michi

        Show
        Michi Mutsuzaki added a comment - -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. No code change. --Michi
        Hide
        Patrick Hunt added a comment -

        Thanks Michi!

        Show
        Patrick Hunt added a comment - Thanks Michi!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1600 (See https://builds.apache.org/job/ZooKeeper-trunk/1600/)
        ZOOKEEPER-1454. Document how to run autoreconf if cppunit is installed in a non-standard directory (Michi Mutsuzaki via phunt) (Revision 1355657)

        Result = SUCCESS
        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355657
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/README
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1600 (See https://builds.apache.org/job/ZooKeeper-trunk/1600/ ) ZOOKEEPER-1454 . Document how to run autoreconf if cppunit is installed in a non-standard directory (Michi Mutsuzaki via phunt) (Revision 1355657) Result = SUCCESS phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355657 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/README

          People

          • Assignee:
            Michi Mutsuzaki
            Reporter:
            Michi Mutsuzaki
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development