ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1445

Add support for binary data for zktreeutil

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 3.4.3
    • Fix Version/s: 3.5.0
    • Component/s: contrib
    • Labels:
      None

      Description

      zktreeutil does not support binary data. The program will fail to import/export znode's data which are in binary format. We are going to use OpenSSL library to perform Base64 encoding so that we can store it XML format. OpenSSL seems to be the only widely available library which as support for Base64 encoding and decoding. Libxml2 only have encoding support.

      1. ZOOKEEPER-1445.patch
        11 kB
        Thawan Kooburat
      2. ZOOKEEPER-1445.patch
        10 kB
        Thawan Kooburat

        Activity

        Hide
        Thawan Kooburat added a comment -

        Use openssl to provide Base64 encoding/decoding

        Show
        Thawan Kooburat added a comment - Use openssl to provide Base64 encoding/decoding
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522368/ZOOKEEPER-1445.patch
        against trunk revision 1307644.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1032//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522368/ZOOKEEPER-1445.patch against trunk revision 1307644. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1032//console This message is automatically generated.
        Hide
        Eugene Koontz added a comment -

        Hi Thawan,

        Looks like a useful feature. However, I noticed in src/contrib/zktreeutil/configure.ac you are setting OPENSSL_LIB_PATH="/usr/lib64. Would this patch not work on 32 bit architectures?

        Show
        Eugene Koontz added a comment - Hi Thawan, Looks like a useful feature. However, I noticed in src/contrib/zktreeutil/configure.ac you are setting OPENSSL_LIB_PATH="/usr/lib64 . Would this patch not work on 32 bit architectures?
        Hide
        Thawan Kooburat added a comment -

        I don't think there will be an issue with 32-bit, so I should be able to change that to /usr/lib. However, I don't have 32 bit machine to test right now, so I am not sure about it.

        If we are interested in this patch and agree on its overall design, I can create a new patch that should apply to the upstream branch.

        Show
        Thawan Kooburat added a comment - I don't think there will be an issue with 32-bit, so I should be able to change that to /usr/lib. However, I don't have 32 bit machine to test right now, so I am not sure about it. If we are interested in this patch and agree on its overall design, I can create a new patch that should apply to the upstream branch.
        Hide
        Thawan Kooburat added a comment -

        Updated patch file

        Show
        Thawan Kooburat added a comment - Updated patch file
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12530248/ZOOKEEPER-1445.patch
        against trunk revision 1337029.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530248/ZOOKEEPER-1445.patch against trunk revision 1337029. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1084//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        I'm canceling this patch for the same reason as ZOOKEEPER-1218. Let's figure out if we have enough bandwidth to support this.

        Show
        Michi Mutsuzaki added a comment - I'm canceling this patch for the same reason as ZOOKEEPER-1218 . Let's figure out if we have enough bandwidth to support this.

          People

          • Assignee:
            Thawan Kooburat
            Reporter:
            Thawan Kooburat
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development