ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1439

c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.3, 3.3.5
    • Fix Version/s: 3.5.0
    • Component/s: c client
    • Labels:
    • Environment:

      linux

    • Hadoop Flags:
      Reviewed
    • Tags:
      sdk

      Description

      Man of getpwuid_r "return a pointer to a passwd structure, or NULL if the matching entry is not found or an error occurs",
      "The getpwnam_r() and getpwuid_r() functions return zero on success.", it means entry may not be found when getpwuid_r success.

      In log_env of zookeeper.c in c sdk:
      if (!getpwuid_r(uid, &pw, buf, sizeof(buf), &pwp)) {
      LOG_INFO(("Client environment:user.home=%s", pw.pw_dir));
      }
      pwp is not checked to ensure entry is found, pw.pw_dir is not initialized in this case, core happens in LOG_INFO.

        Activity

        Michi Mutsuzaki made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Resolution Fixed [ 1 ]
        Patrick Hunt made changes -
        Assignee Yubing Yin [ yin.yubing@gmail.com ]
        Yubing Yin made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Yubing Yin made changes -
        Field Original Value New Value
        Attachment ZOOKEEPER-1439.patch [ 12520815 ]
        Yubing Yin created issue -

          People

          • Assignee:
            Yubing Yin
            Reporter:
            Yubing Yin
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development