ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1426

add version command to the zookeeper server

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 3.3.5
    • Fix Version/s: 3.5.0
    • Component/s: scripts, server
    • Labels:

      Description

      Add a version command to the zkServer.sh.

      Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo

      We could do something similar, hook it into our current version information class (perhaps add main to that class).

      Would also need to add a new "version" command to zkServer.sh that calls this.

      1. ZOOKEEPER-1426-3.patch
        6 kB
        Eli Reisman
      2. ZOOKEEPER-1426-2.patch
        15 kB
        Eli Reisman
      3. ZOOKEEPER-1426-1.patch
        5 kB
        Eli Reisman
      4. MAPREDUCE-4282-2.patch
        1.24 MB
        Eli Reisman

        Activity

        Michi Mutsuzaki made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Michi Mutsuzaki added a comment -

        The patch doesn't apply anymore.

        Show
        Michi Mutsuzaki added a comment - The patch doesn't apply anymore.
        Mahadev konar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good to me. Will try jenkins again before I commit.

        Show
        Mahadev konar added a comment - +1 the patch looks good to me. Will try jenkins again before I commit.
        Mahadev konar made changes -
        Fix Version/s 3.5.0 [ 12316644 ]
        Hide
        Jakob Homan added a comment -

        +1 from me. Thanks for the update. Patrick Hunt, does this look good to you?

        Show
        Jakob Homan added a comment - +1 from me. Thanks for the update. Patrick Hunt , does this look good to you?
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12539752/ZOOKEEPER-1426-3.patch
        against trunk revision 1368737.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539752/ZOOKEEPER-1426-3.patch against trunk revision 1368737. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//console This message is automatically generated.
        Eli Reisman made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Hide
        Eli Reisman added a comment -

        fixed as per your specifications, should be working now.

        Show
        Eli Reisman added a comment - fixed as per your specifications, should be working now.
        Eli Reisman made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Eli Reisman made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Eli Reisman made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Eli Reisman made changes -
        Attachment ZOOKEEPER-1426-3.patch [ 12539752 ]
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Jakob Homan added a comment -

        Canceling patch, post review.

        Show
        Jakob Homan added a comment - Canceling patch, post review.
        Hide
        Jakob Homan added a comment -

        Hey Eli. Looks like the new patch picked up some changes from the changelog. Also, can you look into the new findbugs warning? Thanks.

        Show
        Jakob Homan added a comment - Hey Eli. Looks like the new patch picked up some changes from the changelog. Also, can you look into the new findbugs warning ? Thanks.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12538829/ZOOKEEPER-1426-2.patch
        against trunk revision 1368203.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538829/ZOOKEEPER-1426-2.patch against trunk revision 1368203. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//console This message is automatically generated.
        Eli Reisman made changes -
        Attachment ZOOKEEPER-1426-2.patch [ 12538829 ]
        Hide
        Eli Reisman added a comment -

        lets see if I can click the mouse correctly this time...

        Show
        Eli Reisman added a comment - lets see if I can click the mouse correctly this time...
        Hide
        Eli Reisman added a comment -

        sorry wrong patch, will upload the right one now!

        Show
        Eli Reisman added a comment - sorry wrong patch, will upload the right one now!
        Hide
        Patrick Hunt added a comment -

        for some reason you attached a MAPREDUCE patch? the patch QA bot pulls the most recent attachment to try as the patch (against trunk).

        Show
        Patrick Hunt added a comment - for some reason you attached a MAPREDUCE patch? the patch QA bot pulls the most recent attachment to try as the patch (against trunk).
        Hide
        Eli Reisman added a comment -

        I saw this Hadoop QA notice, so I pulled fresh trunk and applied the patch. it worked fine. It is a git --no-prefix patch, and I used "patch -p0 ..." is that the problem? anyway I don't know what its talking about so I can't fix it yet. Still passes ant compile-test as well.

        Show
        Eli Reisman added a comment - I saw this Hadoop QA notice, so I pulled fresh trunk and applied the patch. it worked fine. It is a git --no-prefix patch, and I used "patch -p0 ..." is that the problem? anyway I don't know what its talking about so I can't fix it yet. Still passes ant compile-test as well.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12538805/MAPREDUCE-4282-2.patch
        against trunk revision 1368072.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 19 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1150//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538805/MAPREDUCE-4282-2.patch against trunk revision 1368072. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1150//console This message is automatically generated.
        Eli Reisman made changes -
        Attachment MAPREDUCE-4282-2.patch [ 12538805 ]
        Hide
        Eli Reisman added a comment -

        Added test, fixed generated class name to include "Main" prefix, etc. passes 'ant compile-test'

        Show
        Eli Reisman added a comment - Added test, fixed generated class name to include "Main" prefix, etc. passes 'ant compile-test'
        Eli Reisman made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Eli Reisman made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Eli Reisman added a comment -

        If you mean the ASF license at the top in comments, its in there, gets generated also. Did you mean something else?
        I will add a test today.

        Show
        Eli Reisman added a comment - If you mean the ASF license at the top in comments, its in there, gets generated also. Did you mean something else? I will add a test today.
        Hide
        Patrick Hunt added a comment -

        Good catch Jakob. It's good to add it whenever possible, esp for source files.

        Eli please add the header as well.

        Show
        Patrick Hunt added a comment - Good catch Jakob. It's good to add it whenever possible, esp for source files. Eli please add the header as well.
        Hide
        Jakob Homan added a comment -

        Is the ASF header required on generated files?

        Show
        Jakob Homan added a comment - Is the ASF header required on generated files?
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Patrick Hunt added a comment -

        We have a convention of calling the main classes *Main. Also please add a test. thanks!

        Show
        Patrick Hunt added a comment - We have a convention of calling the main classes *Main. Also please add a test. thanks!
        Patrick Hunt made changes -
        Assignee Eli Reisman [ initialcontext ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12537373/ZOOKEEPER-1426-1.patch
        against trunk revision 1362660.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537373/ZOOKEEPER-1426-1.patch against trunk revision 1362660. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//console This message is automatically generated.
        Eli Reisman made changes -
        Attachment ZOOKEEPER-1426-1.patch [ 12537373 ]
        Eli Reisman made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 3.3.5 [ 12319081 ]
        Labels newbie newbie patch
        Hide
        Eli Reisman added a comment -

        Added more code generation to VerGen.java to create an implementation class for org.apache.zookeeper.version.Info called org.apache.zookeeper.version.VersionInfo that contains only a main method that prints the hardcoded version data in Info on stdout and can be run from a new command "version" in zkServer.sh

        Show
        Eli Reisman added a comment - Added more code generation to VerGen.java to create an implementation class for org.apache.zookeeper.version.Info called org.apache.zookeeper.version.VersionInfo that contains only a main method that prints the hardcoded version data in Info on stdout and can be run from a new command "version" in zkServer.sh
        Patrick Hunt created issue -

          People

          • Assignee:
            Eli Reisman
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development