ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1423

4lw and jmx should expose the size of the datadir/datalogdir

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.1, 3.6.0
    • Component/s: jmx
    • Labels:

      Description

      There are no metrics currently available on the size of the datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It would be good to expose these metrics through jmx/4lw such that monitoring can be done on the size. Would key ppl in on whether cleanup was actually running. In particular this could be monitored/alerted on by third party systems (nagios, ganglia and the like).

      1. ZOOKEEPER-1423.2.patch
        18 kB
        Edward Ribeiro
      2. ZOOKEEPER-1423.3.patch
        18 kB
        Edward Ribeiro
      3. ZOOKEEPER-1423.4.patch
        12 kB
        Edward Ribeiro
      4. ZOOKEEPER-1423.5.patch
        12 kB
        Edward Ribeiro
      5. ZOOKEEPER-1423.6.patch
        13 kB
        Edward Ribeiro
      6. ZOOKEEPER-1423.7.patch
        13 kB
        Edward Ribeiro
      7. ZOOKEEPER-1423.8.patch
        14 kB
        Edward Ribeiro
      8. ZOOKEEPER-1423.patch
        18 kB
        Edward Ribeiro

        Activity

        Hide
        Edward Ribeiro added a comment -

        Hi folks,

        I am sending a first version of a patch to address this issue. I am aware that it should probably be rewritten to be in sync with ZOOKEEPER-1346, but I hope you have time to evaluate it and see if it's okay to include in 3.5.

        Any suggestion/correction is welcome.

        Cheers,
        E.

        Show
        Edward Ribeiro added a comment - Hi folks, I am sending a first version of a patch to address this issue. I am aware that it should probably be rewritten to be in sync with ZOOKEEPER-1346 , but I hope you have time to evaluate it and see if it's okay to include in 3.5. Any suggestion/correction is welcome. Cheers, E.
        Hide
        Edward Ribeiro added a comment -

        Adding a new version of the patch.

        Show
        Edward Ribeiro added a comment - Adding a new version of the patch.
        Hide
        Edward Ribeiro added a comment -

        This patch will need to be reworked so that it can be in sync with changes of ZOOKEEPER-1346, but I am uploading so that you see if it's alright.

        Show
        Edward Ribeiro added a comment - This patch will need to be reworked so that it can be in sync with changes of ZOOKEEPER-1346 , but I am uploading so that you see if it's alright.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12566395/ZOOKEEPER-1423.2.patch
        against trunk revision 1437257.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566395/ZOOKEEPER-1423.2.patch against trunk revision 1437257. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//console This message is automatically generated.
        Hide
        Edward Ribeiro added a comment -

        Excuse me, forgot two unused fields in ServerStats. Fixed.

        Show
        Edward Ribeiro added a comment - Excuse me, forgot two unused fields in ServerStats. Fixed.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12566406/ZOOKEEPER-1423.3.patch
        against trunk revision 1437257.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566406/ZOOKEEPER-1423.3.patch against trunk revision 1437257. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1362//console This message is automatically generated.
        Hide
        Rakesh R added a comment -

        Thanks Edward for the patch, lgtm mostly. I've few comments, please see:

        1. Format issues, please correct
          +	public long getDataDirSize();
          +        public long getLogDirSize();
          
          +
          +    public long getDataDirSize() {
          +	return provider.getDataDirSize();
          +    }
          +
          +    public long getLogDirSize() {
          +	return provider.getLogDirSize();
          +    }
          
        2. Can we print the o/p in a single line like:
          "datadir: " + dir + "size: " + dataSize
          "logdir: " + dir + "size: " + logSize
          
        3. Small correction,
          the total size of data and log (snapshot) directories' content in bytes.
          

          Actually it should be snapshot and log, can we rephrase like:

          the total size of snapshot and log files in bytes
          
        4. I feel, its good to expose the dirs path in MBean too.
        5. please provide javadocs for #getDataDirSize() and #getLogDirSize()
        Show
        Rakesh R added a comment - Thanks Edward for the patch, lgtm mostly. I've few comments, please see: Format issues, please correct + public long getDataDirSize(); + public long getLogDirSize(); + + public long getDataDirSize() { + return provider.getDataDirSize(); + } + + public long getLogDirSize() { + return provider.getLogDirSize(); + } Can we print the o/p in a single line like: "datadir: " + dir + "size: " + dataSize "logdir: " + dir + "size: " + logSize Small correction, the total size of data and log (snapshot) directories' content in bytes. Actually it should be snapshot and log, can we rephrase like: the total size of snapshot and log files in bytes I feel, its good to expose the dirs path in MBean too. please provide javadocs for #getDataDirSize() and #getLogDirSize()
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12566406/ZOOKEEPER-1423.3.patch
        against trunk revision 1582572.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1992//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566406/ZOOKEEPER-1423.3.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1992//console This message is automatically generated.
        Hide
        Edward Ribeiro added a comment -

        Resuming work on this ticket by attaching a new patch compatible with last year's ZK changes.

        Show
        Edward Ribeiro added a comment - Resuming work on this ticket by attaching a new patch compatible with last year's ZK changes.
        Hide
        Raul Gutierrez Segales added a comment -

        Thanks for the patch Edward Ribeiro! A few nits:

        In:

        +    @Override
        +    public long getDataDirSize() {
        +        if (zkDb == null) return 0L;
        +        File path = zkDb.snapLog.getDataDir();
        +        return getDirSize(path);
        +    }
        +
        +    @Override
        +    public long getLogDirSize() {
        

        please use {} for if statements, even the body only has 1 statement. I.e.:

        +    public long getDataDirSize() {
        +        if (zkDb == null) {
        +          return 0L;
        +        }
        +        File path = zkDb.snapLog.getDataDir();
        +        return getDirSize(path);
        +    }
        

        Ditto for getLogDirSize(). Other than, lgtm. Will do one more pass after the nits are addressed - thanks!

        Show
        Raul Gutierrez Segales added a comment - Thanks for the patch Edward Ribeiro ! A few nits: In: + @Override + public long getDataDirSize() { + if (zkDb == null ) return 0L; + File path = zkDb.snapLog.getDataDir(); + return getDirSize(path); + } + + @Override + public long getLogDirSize() { please use {} for if statements, even the body only has 1 statement. I.e.: + public long getDataDirSize() { + if (zkDb == null ) { + return 0L; + } + File path = zkDb.snapLog.getDataDir(); + return getDirSize(path); + } Ditto for getLogDirSize(). Other than, lgtm. Will do one more pass after the nits are addressed - thanks!
        Hide
        Edward Ribeiro added a comment -

        Thanks for the quick reply and review, Raul Gutierrez Segales!

        I am submitting a new patch with the points above addressed. Let me know, it there's any thing to fix/improve in the next review round.

        Cheers!
        Edward

        Show
        Edward Ribeiro added a comment - Thanks for the quick reply and review, Raul Gutierrez Segales ! I am submitting a new patch with the points above addressed. Let me know, it there's any thing to fix/improve in the next review round. Cheers! Edward
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12744274/ZOOKEEPER-1423.5.patch
        against trunk revision 1689571.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2809//testReport/
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2809//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12744274/ZOOKEEPER-1423.5.patch against trunk revision 1689571. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2809//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2809//console This message is automatically generated.
        Hide
        Edward Ribeiro added a comment -

        Oops, excuse me, the patch was lacking a new file. Updating now. Let me know if you have any further considerations.

        Show
        Edward Ribeiro added a comment - Oops, excuse me, the patch was lacking a new file. Updating now. Let me know if you have any further considerations.
        Hide
        Raul Gutierrez Segales added a comment -

        In:

        +    private long getDirSize(File dir) {
        +        long size = dir.length();
        +        if (dir.isDirectory()) {
        +            for (File f: dir.listFiles()) {
        +                size += getDirSize(f);
        +            }
        +        }
        +        return size;
        +    }
        

        Is calling length() on a directory reliable? According to http://docs.oracle.com/javase/7/docs/api/java/io/File.html#length(), it's not defined:

        "Returns the length of the file denoted by this abstract pathname. The return value is unspecified if this pathname denotes a directory."

        Though running a test prog on Linux (i.e.: https://gist.github.com/rgs1/31e57c9bf2ddcb2c8018) it does show the right thing. I wonder if it breaks on other platforms... If so, we probably shouldn't add up the size of the directory.

        One last nit, in:

        +package org.apache.zookeeper.server.command;
        +
        +
        +import org.apache.zookeeper.server.ServerCnxn;
        +
        +import java.io.IOException;
        +import java.io.PrintWriter;
        +
        

        The stdlib imports usually go first, so it would be:

        +import java.io.IOException;
        +import java.io.PrintWriter;
        +
        +import org.apache.zookeeper.server.ServerCnxn;
        
        Show
        Raul Gutierrez Segales added a comment - In: + private long getDirSize(File dir) { + long size = dir.length(); + if (dir.isDirectory()) { + for (File f: dir.listFiles()) { + size += getDirSize(f); + } + } + return size; + } Is calling length() on a directory reliable? According to http://docs.oracle.com/javase/7/docs/api/java/io/File.html#length( ), it's not defined: "Returns the length of the file denoted by this abstract pathname. The return value is unspecified if this pathname denotes a directory." Though running a test prog on Linux (i.e.: https://gist.github.com/rgs1/31e57c9bf2ddcb2c8018 ) it does show the right thing. I wonder if it breaks on other platforms... If so, we probably shouldn't add up the size of the directory. One last nit, in: + package org.apache.zookeeper.server.command; + + + import org.apache.zookeeper.server.ServerCnxn; + + import java.io.IOException; + import java.io.PrintWriter; + The stdlib imports usually go first, so it would be: + import java.io.IOException; + import java.io.PrintWriter; + + import org.apache.zookeeper.server.ServerCnxn;
        Hide
        Edward Ribeiro added a comment -

        Good catch about the directory length, Raul Gutierrez Segales! My tests were exclusively on Linux where it worked but it's definitely not safe to use it for directories, as explained here http://stackoverflow.com/questions/12432135/what-does-java-io-file-length-return-for-a-directory , changed accordingly. Also, changed the import order, both changes in ZOOKEEPER-1423.7.patch

        Show
        Edward Ribeiro added a comment - Good catch about the directory length, Raul Gutierrez Segales ! My tests were exclusively on Linux where it worked but it's definitely not safe to use it for directories, as explained here http://stackoverflow.com/questions/12432135/what-does-java-io-file-length-return-for-a-directory , changed accordingly. Also, changed the import order, both changes in ZOOKEEPER-1423 .7.patch
        Hide
        Edward Ribeiro added a comment -

        Just a minor addendum: I had included the dir.length() just because then its calculated numbers would not differ by the 4K bytes, per Linux directory, from du command, for example (see below). But, I completely agree that its inclusion would be very risky on multi-platform settings.

        $ echo dirs | nc localhost 2181
        datadir_size: 67109658
        logdir_size: 67109658
        
        $ du -b /var/zookeeper/data
        67113754	/var/zookeeper/data/version-2
        67117854	/var/zookeeper/data
        
        Show
        Edward Ribeiro added a comment - Just a minor addendum: I had included the dir.length() just because then its calculated numbers would not differ by the 4K bytes, per Linux directory, from du command, for example (see below). But, I completely agree that its inclusion would be very risky on multi-platform settings. $ echo dirs | nc localhost 2181 datadir_size: 67109658 logdir_size: 67109658 $ du -b / var /zookeeper/data 67113754 / var /zookeeper/data/version-2 67117854 / var /zookeeper/data
        Hide
        Raul Gutierrez Segales added a comment -

        Thanks Edward Ribeiro! One last nit (though, a bit more than a nit since it's a legal thing : the license header is missing in src/java/main/org/apache/zookeeper/server/command/DirsCommand.java. After that I am happy to merge it, +1.

        Thanks!

        Show
        Raul Gutierrez Segales added a comment - Thanks Edward Ribeiro ! One last nit (though, a bit more than a nit since it's a legal thing : the license header is missing in src/java/main/org/apache/zookeeper/server/command/DirsCommand.java. After that I am happy to merge it, +1. Thanks!
        Hide
        Edward Ribeiro added a comment -

        Thanks for the review, let me know if there's something to change. Added the license header.

        ps: as the status was changed to 'Patch Available' the Hadoop QA bot should be running now, right?

        Show
        Edward Ribeiro added a comment - Thanks for the review, let me know if there's something to change. Added the license header. ps: as the status was changed to 'Patch Available' the Hadoop QA bot should be running now, right?
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12744356/ZOOKEEPER-1423.8.patch
        against trunk revision 1689571.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12744356/ZOOKEEPER-1423.8.patch against trunk revision 1689571. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2810//console This message is automatically generated.
        Hide
        Raul Gutierrez Segales added a comment -

        Merged: http://svn.apache.org/viewvc?view=revision&revision=1690207 (github mirror lagging, apparently). Thanks Edward Ribeiro!

        Michi Mutsuzaki: shall I merge this for 3.5 too?

        Show
        Raul Gutierrez Segales added a comment - Merged: http://svn.apache.org/viewvc?view=revision&revision=1690207 (github mirror lagging, apparently). Thanks Edward Ribeiro ! Michi Mutsuzaki : shall I merge this for 3.5 too?
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in ZooKeeper-trunk #2749 (See https://builds.apache.org/job/ZooKeeper-trunk/2749/)
        ZOOKEEPER-1423: 4lw and jmx should expose the size of the datadir/datalogdir
        (Edward Ribeiro via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1690207)

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerStats.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/admin/Commands.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/CommandExecutor.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/DirsCommand.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
        Show
        Hudson added a comment - SUCCESS: Integrated in ZooKeeper-trunk #2749 (See https://builds.apache.org/job/ZooKeeper-trunk/2749/ ) ZOOKEEPER-1423 : 4lw and jmx should expose the size of the datadir/datalogdir (Edward Ribeiro via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1690207 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerStats.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/admin/Commands.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/CommandExecutor.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/DirsCommand.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
        Show
        Raul Gutierrez Segales added a comment - Merged for 3.5 as well: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1690565

          People

          • Assignee:
            Edward Ribeiro
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development