Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.0
    • Component/s: java client
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      The output of ls-command in CLI does not contain the []-frame any more. Instead the nodes are sorted.

      Description

      Sort the output of the ls-command in the CLI. And remove the [] frame.

      Example: change output of "ls /"
      [test1, aa3, zkc1, aa2, aa1, zookeeper]
      to
      aa1, aa2, aa3, test1, zk1, zookeeper

      1. ZOOKEEPER-1408.patch
        7 kB
        Hartmut Lang
      2. ZOOKEEPER-1408.patch
        10 kB
        Hartmut Lang
      3. ZOOKEEPER-1408.patch
        10 kB
        Patrick Hunt
      4. ZOOKEEPER-1408.patch
        11 kB
        Michi Mutsuzaki

        Issue Links

          Activity

          Hide
          Hartmut Lang added a comment -

          I'd also like to remove the square brackets around the list of nodes.
          The brackets just happened to be there, because a toString call of a list-object was used.

          Show
          Hartmut Lang added a comment - I'd also like to remove the square brackets around the list of nodes. The brackets just happened to be there, because a toString call of a list-object was used.
          Hide
          Hartmut Lang added a comment -

          The jline completion options for nodes should also be sorted.

          Show
          Hartmut Lang added a comment - The jline completion options for nodes should also be sorted.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518832/ZOOKEEPER-1408.patch
          against trunk revision 1302073.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/998//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/998//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/998//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518832/ZOOKEEPER-1408.patch against trunk revision 1302073. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/998//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/998//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/998//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          Sounds good. Can we add a test for this as well?

          Also, the format of the output is different. We should mark as an "incompatible change" and add a release note (to rel note field of this jira). Thanks!

          Show
          Patrick Hunt added a comment - Sounds good. Can we add a test for this as well? Also, the format of the output is different. We should mark as an "incompatible change" and add a release note (to rel note field of this jira). Thanks!
          Hide
          Hartmut Lang added a comment -

          New patch with test-case added.
          Marked as incompatible change and added release-notes content.

          Show
          Hartmut Lang added a comment - New patch with test-case added. Marked as incompatible change and added release-notes content.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12519858/ZOOKEEPER-1408.patch
          against trunk revision 1302736.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1011//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1011//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1011//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519858/ZOOKEEPER-1408.patch against trunk revision 1302736. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1011//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1011//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1011//console This message is automatically generated.
          Hide
          Edward Ribeiro added a comment -

          Hi Patrick Hunt, Flavio Junqueira and Camille Fournier,

          Looks good to me. Any problem with having this patch committed?

          Cheers,
          Edward Ribeiro

          Show
          Edward Ribeiro added a comment - Hi Patrick Hunt , Flavio Junqueira and Camille Fournier , Looks good to me. Any problem with having this patch committed? Cheers, Edward Ribeiro
          Hide
          Patrick Hunt added a comment -

          I updated this patch to apply to latest trunk.

          I also updated the patch to be b/w compatible with the previous output - in particular I included the [ and ] framing on the output. This will minimize disruption on downstream users, and afaict there is no good reason to remove it at this point (I realize it's unnecessary, and if I had to do it over again I would not have it there, but given all previous releases had it I'm reticent to break all existing users for no good reason. LMK if you strongly disagree, otw I'll commit this)

          Show
          Patrick Hunt added a comment - I updated this patch to apply to latest trunk. I also updated the patch to be b/w compatible with the previous output - in particular I included the [ and ] framing on the output. This will minimize disruption on downstream users, and afaict there is no good reason to remove it at this point (I realize it's unnecessary, and if I had to do it over again I would not have it there, but given all previous releases had it I'm reticent to break all existing users for no good reason. LMK if you strongly disagree, otw I'll commit this)
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12607245/ZOOKEEPER-1408.patch
          against trunk revision 1530029.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1646//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1646//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1646//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607245/ZOOKEEPER-1408.patch against trunk revision 1530029. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1646//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1646//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1646//console This message is automatically generated.
          Hide
          Michi Mutsuzaki added a comment -

          The patch doesn't apply anymore. I'll resolve the conflict and upload a new patch.

          Show
          Michi Mutsuzaki added a comment - The patch doesn't apply anymore. I'll resolve the conflict and upload a new patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12637595/ZOOKEEPER-1408.patch
          against trunk revision 1582572.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637595/ZOOKEEPER-1408.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1997//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12637595/ZOOKEEPER-1408.patch
          against trunk revision 1582572.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637595/ZOOKEEPER-1408.patch against trunk revision 1582572. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1998//console This message is automatically generated.
          Hide
          Michi Mutsuzaki added a comment -

          +1 I'm checking this in.

          Show
          Michi Mutsuzaki added a comment - +1 I'm checking this in.
          Show
          Michi Mutsuzaki added a comment - trunk: http://svn.apache.org/viewvc?view=revision&revision=1582943
          Hide
          Hudson added a comment -

          FAILURE: Integrated in ZooKeeper-trunk #2272 (See https://builds.apache.org/job/ZooKeeper-trunk/2272/)
          ZOOKEEPER-1408. CLI: sort output of ls command (Hartmut Lang via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1582943)

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/JLineZNodeCompleter.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/CliCommand.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/CreateCommand.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/DeleteCommand.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/Ls2Command.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/LsCommand.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/SetAclCommand.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/ZooKeeperTest.java
          Show
          Hudson added a comment - FAILURE: Integrated in ZooKeeper-trunk #2272 (See https://builds.apache.org/job/ZooKeeper-trunk/2272/ ) ZOOKEEPER-1408 . CLI: sort output of ls command (Hartmut Lang via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1582943 ) /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/JLineZNodeCompleter.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/CliCommand.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/CreateCommand.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/DeleteCommand.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/Ls2Command.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/LsCommand.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/SetAclCommand.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/ZooKeeperTest.java

            People

            • Assignee:
              Hartmut Lang
              Reporter:
              Hartmut Lang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development