ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1389

it would be nice if start-foreground used exec $JAVA in order to get rid of the intermediate shell process

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.2
    • Fix Version/s: 3.3.5, 3.4.4, 3.5.0
    • Component/s: scripts, server
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A log of daemon management tools expect a process itself to be running as a child instead of a grand-child. It would be nice if we had an option for that in zkServer.sh

      1. ZOOKEEPER-1389.patch.txt
        0.5 kB
        Roman Shaposhnik

        Activity

        Hide
        Roman Shaposhnik added a comment -

        Attaching a patch against trunk/branch-3.4

        Show
        Roman Shaposhnik added a comment - Attaching a patch against trunk/branch-3.4
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513853/ZOOKEEPER-1389.patch.txt
        against trunk revision 1240959.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513853/ZOOKEEPER-1389.patch.txt against trunk revision 1240959. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/954//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Thanks Roman.

        Show
        Patrick Hunt added a comment - Thanks Roman.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1461 (See https://builds.apache.org/job/ZooKeeper-trunk/1461/)
        ZOOKEEPER-1389. it would be nice if start-foreground used exec in order to get rid of the intermediate shell process (Roman Shaposhnik via phunt) (Revision 1244776)

        Result = FAILURE
        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244776
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/bin/zkServer.sh
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1461 (See https://builds.apache.org/job/ZooKeeper-trunk/1461/ ) ZOOKEEPER-1389 . it would be nice if start-foreground used exec in order to get rid of the intermediate shell process (Roman Shaposhnik via phunt) (Revision 1244776) Result = FAILURE phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244776 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/bin/zkServer.sh

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development