ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1377

add support for dumping a snapshot file content (similar to LogFormatter)

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: server
    • Labels:

      Description

      We have LogFormatter but not SnapshotFormatter. I've added this, patch momentarily.

      1. ZOOKEEPER-1377.patch
        7 kB
        Patrick Hunt
      2. ZOOKEEPER-1377.patch
        7 kB
        Patrick Hunt

        Activity

        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1499 (See https://builds.apache.org/job/ZooKeeper-trunk/1499/)
        ZOOKEEPER-1377. add support for dumping a snapshot file content (similar to LogFormatter) (phunt via camille) (Revision 1302213)

        Result = SUCCESS
        camille : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302213
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/build.xml
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SnapshotFormatter.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/InvalidSnapshotTest.java
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1499 (See https://builds.apache.org/job/ZooKeeper-trunk/1499/ ) ZOOKEEPER-1377 . add support for dumping a snapshot file content (similar to LogFormatter) (phunt via camille) (Revision 1302213) Result = SUCCESS camille : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1302213 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/build.xml /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SnapshotFormatter.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/InvalidSnapshotTest.java
        Hide
        Patrick Hunt added a comment -

        Sounds reasonable to me given it's a standalone (debug) utility. Feel free. Thx

        Show
        Patrick Hunt added a comment - Sounds reasonable to me given it's a standalone (debug) utility. Feel free. Thx
        Hide
        Camille Fournier added a comment -

        +1 looks nice. Should we consider adding this to 3.4? I realize it's a "new feature" but it is also an awfully useful utility.

        Show
        Camille Fournier added a comment - +1 looks nice. Should we consider adding this to 3.4? I realize it's a "new feature" but it is also an awfully useful utility.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12512218/ZOOKEEPER-1377.patch
        against trunk revision 1234974.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512218/ZOOKEEPER-1377.patch against trunk revision 1234974. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/925//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        fixed the (bogus) findbugs warning

        Show
        Patrick Hunt added a comment - fixed the (bogus) findbugs warning
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12512211/ZOOKEEPER-1377.patch
        against trunk revision 1234974.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512211/ZOOKEEPER-1377.patch against trunk revision 1234974. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/924//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Added, plus test and include in public javadoc.

        Show
        Patrick Hunt added a comment - Added, plus test and include in public javadoc.

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development