ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1353

C client test suite fails consistently

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.4
    • Fix Version/s: 3.4.3, 3.3.5, 3.5.0
    • Component/s: c client, tests
    • Labels:
    • Environment:

      Ubuntu precise (dev release), amd64

    • Hadoop Flags:
      Reviewed

      Description

      When the c client test suite, zktest-mt, is run, it fails with this:

      tests/TestZookeeperInit.cc:233: Assertion: equality assertion failed [Expected: 2, Actual : 22]

      This was also reported in 3.3.1 here:

      http://www.mail-archive.com/zookeeper-dev@hadoop.apache.org/msg08914.html

      The C client tests are making some assumptions that are not valid. getaddrinfo may have, at one time, returned ENOENT instead of EINVAL for the host given in the test. The assertion should simply be that EINVAL | ENOENT are given, so that builds on platforms which return ENOENT for this are not broken.

        Activity

        Hide
        Clint Byrum added a comment -
        Show
        Clint Byrum added a comment - Tracked in Ubuntu here: https://bugs.launchpad.net/ubuntu/+source/zookeeper/+bug/912935
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12509719/fix-broken-c-client-unittest.patch
        against trunk revision 1227927.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/886//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509719/fix-broken-c-client-unittest.patch against trunk revision 1227927. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/886//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Hi Clint, our systems expect the patch to be relative to the toplevel "trunk" directory. I've updated that patch to address this time around. For future reference, we typically name the patches as ZOOKEEPER-####.patch where #### is the jira number. Thanks for the submission!
        https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

        Show
        Patrick Hunt added a comment - Hi Clint, our systems expect the patch to be relative to the toplevel "trunk" directory. I've updated that patch to address this time around. For future reference, we typically name the patches as ZOOKEEPER-####.patch where #### is the jira number. Thanks for the submission! https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12509759/fix-broken-c-client-unittest.patch
        against trunk revision 1227927.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/887//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/887//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/887//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509759/fix-broken-c-client-unittest.patch against trunk revision 1227927. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/887//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/887//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/887//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        Thanks for pointing this out (and also for the patch) Clint.

        Show
        Mahadev konar added a comment - Thanks for pointing this out (and also for the patch) Clint.
        Hide
        Mahadev konar added a comment -

        I just committed to all 3 branches. Thanks Clint!

        Show
        Mahadev konar added a comment - I just committed to all 3 branches. Thanks Clint!
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1451 (See https://builds.apache.org/job/ZooKeeper-trunk/1451/)
        ZOOKEEPER-1353. C client test suite fails consistently. (Clint Byrum via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240905
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/tests/TestZookeeperInit.cc
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1451 (See https://builds.apache.org/job/ZooKeeper-trunk/1451/ ) ZOOKEEPER-1353 . C client test suite fails consistently. (Clint Byrum via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240905 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/tests/TestZookeeperInit.cc

          People

          • Assignee:
            Clint Byrum
            Reporter:
            Clint Byrum
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 5m
              5m
              Remaining:
              Remaining Estimate - 5m
              5m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development