[ZOOKEEPER-1328] Misplaced assertion for the test case 'FLELostMessageTest' and not identifying misfunctions

• Type: Test
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.5.0
• Component/s: leaderElection
• Hadoop Flags: Reviewed
• Assignee: Rakesh Radhakrishnan
• Reporter: Rakesh Radhakrishnan
• Created: 13/Dec/11 05:46
• Updated: 03/Sep/12 11:01
• Resolved: 03/Sep/12 05:59

Description

Assertion for testLostMessage is kept inside the thread.run() method. Due to this the assertion failure will not be reflected in the main testcase.
I have observed the test case is still passing in case of the assert failure or misfunction. Instead, the assertion can be moved to the test case - testLostMessage.

class LEThread extends Thread {
          public void run(){
                peer.setCurrentVote(v);
                LOG.info("Finished election: " + i + ", " + v.getId());
                Assert.assertTrue("State is not leading.", peer.getPeerState() == ServerState.LEADING);
             }