ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1307

zkCli.sh is exiting when an Invalid ACL exception is thrown from setACL command through client

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: java client
    • Labels:
    • Environment:

      zkCli.sh

    • Hadoop Flags:
      Reviewed

      Description

      use consoleClient (zkCli.sh) and issue setAcl /temp abc
      [zk: XX.XX.XX.XX:XXXX(CONNECTED) 17] setAcl /temp abc
      abc does not have the form scheme:id:perm
      Exception in thread "main" org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL
      at org.apache.zookeeper.ZooKeeper.setACL(ZooKeeper.java:1172)
      at org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:717)
      at org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:582)
      at org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:354)
      at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:312)
      at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:271)
      linux-xxx:/zookeeper1/bin #

      if any InvalidACLException is thrown then client is exiting.
      client should be able to handle this kind of issues

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          47d 1h 16m 1 kavita sharma 09/Jan/12 10:23
          Patch Available Patch Available Resolved Resolved
          67d 14h 18m 1 Patrick Hunt 17/Mar/12 00:42
          Eugene Koontz made changes -
          Link This issue is related to ZOOKEEPER-1391 [ ZOOKEEPER-1391 ]
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1494 (See https://builds.apache.org/job/ZooKeeper-trunk/1494/)
          ZOOKEEPER-1307. zkCli.sh is exiting when an Invalid ACL exception is thrown from setACL command through client (Kavita Sharma via phunt) (Revision 1301840)

          Result = SUCCESS
          phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301840
          Files :

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/ZooKeeperTest.java
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1494 (See https://builds.apache.org/job/ZooKeeper-trunk/1494/ ) ZOOKEEPER-1307 . zkCli.sh is exiting when an Invalid ACL exception is thrown from setACL command through client (Kavita Sharma via phunt) (Revision 1301840) Result = SUCCESS phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301840 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/ZooKeeperTest.java
          Patrick Hunt made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 3.4.4 [ 12319841 ]
          Resolution Fixed [ 1 ]
          Hide
          Patrick Hunt added a comment -

          Thanks Kavita!

          (just a couple nits - we use spaces a bit more liberally (compare your changes to the surrounding code), also we typically don't import *, it's fine this go round (I committed your patch unchanged) but for future, regards)

          Show
          Patrick Hunt added a comment - Thanks Kavita! (just a couple nits - we use spaces a bit more liberally (compare your changes to the surrounding code), also we typically don't import *, it's fine this go round (I committed your patch unchanged) but for future, regards)
          Hide
          Hartmut Lang added a comment -

          The changes done for ZOOKEEPER-271 will also fix this issue.

          Show
          Hartmut Lang added a comment - The changes done for ZOOKEEPER-271 will also fix this issue.
          Hartmut Lang made changes -
          Link This issue is superceded by ZOOKEEPER-271 [ ZOOKEEPER-271 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12509891/ZOOKEEPER-1307.patch
          against trunk revision 1227927.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/888//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/888//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/888//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509891/ZOOKEEPER-1307.patch against trunk revision 1227927. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/888//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/888//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/888//console This message is automatically generated.
          kavita sharma made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          kavita sharma made changes -
          Attachment ZOOKEEPER-1307.patch [ 12509891 ]
          Mahadev konar made changes -
          Fix Version/s 3.4.1 [ 12318650 ]
          Fix Version/s 3.3.5 [ 12319081 ]
          Patrick Hunt made changes -
          Labels newbie
          Patrick Hunt made changes -
          Fix Version/s 3.5.0 [ 12316644 ]
          Fix Version/s 3.4.1 [ 12318650 ]
          kavita sharma made changes -
          Field Original Value New Value
          Assignee kavita sharma [ kavita sharma ]
          amith created issue -

            People

            • Assignee:
              kavita sharma
              Reporter:
              amith
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development