ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1303

Observer LearnerHandlers are not removed from Leader collection.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.3.4
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: scripts
    • Labels:
      None

      Description

      The Leader.removeLearnerHandler() call removes handlers from the forwardingFollowers and learners sets, but not from observingLearners. This will cause a leak if observers are repeatedly connected and disconnected from the ensemble.

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12504139/removeObservingLearners.diff
        against trunk revision 1202557.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/793//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504139/removeObservingLearners.diff against trunk revision 1202557. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/793//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        the patch is failing to apply - was it created against trunk?

        Show
        Patrick Hunt added a comment - the patch is failing to apply - was it created against trunk?
        Hide
        Rakesh R added a comment -

        Hi, It seems this has been fixed as part of ZOOKEEPER-1361. Can we close this issue?

        Show
        Rakesh R added a comment - Hi, It seems this has been fixed as part of ZOOKEEPER-1361 . Can we close this issue?
        Hide
        Michi Mutsuzaki added a comment -

        This has been fixed in ZOOKEEPER-1361 as Rakesh pointed out.

        Show
        Michi Mutsuzaki added a comment - This has been fixed in ZOOKEEPER-1361 as Rakesh pointed out.

          People

          • Assignee:
            Ashish Mishra
            Reporter:
            Ashish Mishra
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 168h
              168h
              Remaining:
              Remaining Estimate - 168h
              168h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development