Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.5.0
    • Component/s: java client
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In order to get a Stat object after creation one has to do another exists() call. This leaves client code vulnerable to a possible update window by another writer. All synchronous methods but the create() method allow to pass in a Stat object for population. It would be nice if the create() method would also allow this.

      1. ZOOKEEPER-1297.patch
        68 kB
        Lenni Kuff
      2. ZOOKEEPER-1297.patch
        68 kB
        Lenni Kuff
      3. ZOOKEEPER-1297.patch
        68 kB
        Lenni Kuff

        Issue Links

          Activity

          Hide
          Patrick Hunt added a comment -

          Does seem like an oversight to me. We might be able to append this data to the current response and still have it be backward compatible on the wire. We could then overload the Java methods and introduce new methods on the C client side.

          Would be a great project for a new contributor.

          Show
          Patrick Hunt added a comment - Does seem like an oversight to me. We might be able to append this data to the current response and still have it be backward compatible on the wire. We could then overload the Java methods and introduce new methods on the C client side. Would be a great project for a new contributor.
          Hide
          Lenni Kuff added a comment -

          Added support for returning a Stat object from create() calls. Patch updates both the Java API as well as the C API and CLI.

          Show
          Lenni Kuff added a comment - Added support for returning a Stat object from create() calls. Patch updates both the Java API as well as the C API and CLI.
          Hide
          Lenni Kuff added a comment -

          Posted patch on review board: https://reviews.apache.org/r/7283/

          Show
          Lenni Kuff added a comment - Posted patch on review board: https://reviews.apache.org/r/7283/
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546656/ZOOKEEPER-1297.patch
          against trunk revision 1389711.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 28 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1189//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1189//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1189//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546656/ZOOKEEPER-1297.patch against trunk revision 1389711. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 28 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1189//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1189//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1189//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546656/ZOOKEEPER-1297.patch
          against trunk revision 1410731.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 28 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1269//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1269//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1269//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546656/ZOOKEEPER-1297.patch against trunk revision 1410731. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 28 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1269//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1269//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1269//console This message is automatically generated.
          Hide
          Lenni Kuff added a comment -

          Rebased to latest mainline

          Show
          Lenni Kuff added a comment - Rebased to latest mainline
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554302/ZOOKEEPER-1297.patch
          against trunk revision 1410731.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 28 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1270//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1270//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1270//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554302/ZOOKEEPER-1297.patch against trunk revision 1410731. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 28 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1270//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1270//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1270//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554302/ZOOKEEPER-1297.patch
          against trunk revision 1422473.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 28 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1298//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1298//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1298//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554302/ZOOKEEPER-1297.patch against trunk revision 1422473. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 28 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1298//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1298//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1298//console This message is automatically generated.
          Hide
          Lenni Kuff added a comment -

          Rebased to latest trunk

          Show
          Lenni Kuff added a comment - Rebased to latest trunk
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12561531/ZOOKEEPER-1297.patch
          against trunk revision 1422772.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 28 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1307//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1307//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1307//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561531/ZOOKEEPER-1297.patch against trunk revision 1422772. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 28 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1307//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1307//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1307//console This message is automatically generated.
          Hide
          Patrick Hunt added a comment -

          Great job, thanks Lenni! Committed to trunk.

          Show
          Patrick Hunt added a comment - Great job, thanks Lenni! Committed to trunk.
          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1778 (See https://builds.apache.org/job/ZooKeeper-trunk/1778/)
          ZOOKEEPER-1297. Add stat information to create() call (Lenni Kuff via phunt) (Revision 1423996)

          Result = SUCCESS
          phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1423996
          Files :

          • /zookeeper/trunk/CHANGES.txt
          • /zookeeper/trunk/src/c/include/proto.h
          • /zookeeper/trunk/src/c/include/zookeeper.h
          • /zookeeper/trunk/src/c/src/cli.c
          • /zookeeper/trunk/src/c/src/zookeeper.c
          • /zookeeper/trunk/src/c/tests/TestClient.cc
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/AsyncCallback.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/MultiResponse.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/MultiTransactionRecord.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/OpResult.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooDefs.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java
          • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/AsyncOps.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/AsyncOpsTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CreateTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SyncCallTest.java
          • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java
          • /zookeeper/trunk/src/zookeeper.jute
          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1778 (See https://builds.apache.org/job/ZooKeeper-trunk/1778/ ) ZOOKEEPER-1297 . Add stat information to create() call (Lenni Kuff via phunt) (Revision 1423996) Result = SUCCESS phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1423996 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/include/proto.h /zookeeper/trunk/src/c/include/zookeeper.h /zookeeper/trunk/src/c/src/cli.c /zookeeper/trunk/src/c/src/zookeeper.c /zookeeper/trunk/src/c/tests/TestClient.cc /zookeeper/trunk/src/java/main/org/apache/zookeeper/AsyncCallback.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/MultiResponse.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/MultiTransactionRecord.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/OpResult.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooDefs.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/AsyncOps.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/AsyncOpsTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CreateTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SyncCallTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java /zookeeper/trunk/src/zookeeper.jute

            People

            • Assignee:
              Lenni Kuff
              Reporter:
              Gunnar Wagenknecht
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development