Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.5.0
    • Component/s: c client
    • Labels:
    • Environment:

      Redhat linux

      Description

      When I repeat add watcher , there are a memory leak.

        Activity

        Hide
        Mahadev konar added a comment -

        Peng,
        Can you please reupload the patch and grant license to apache for inclusion?

        Thanks

        Show
        Mahadev konar added a comment - Peng, Can you please reupload the patch and grant license to apache for inclusion? Thanks
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12500389/ZOOKEEPER-1242.patch
        against trunk revision 1188523.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/652//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/652//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/652//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500389/ZOOKEEPER-1242.patch against trunk revision 1188523. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/652//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/652//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/652//console This message is automatically generated.
        Hide
        Peng Futian added a comment -

        Please help me finished this issue. thank you.

        Show
        Peng Futian added a comment - Please help me finished this issue. thank you.
        Hide
        Mahadev konar added a comment -

        @Peng,
        The jira seems to be resolved? The patch doesnt seem to be committed, any reason you marked this resolved?

        Show
        Mahadev konar added a comment - @Peng, The jira seems to be resolved? The patch doesnt seem to be committed, any reason you marked this resolved?
        Hide
        Peng Futian added a comment -

        Index: src/c/src/zk_hashtable.c
        ===================================================================
        — src/c/src/zk_hashtable.c (修订版 1187635)
        +++ src/c/src/zk_hashtable.c (工作拷贝)
        @@ -190,7 +190,7 @@
        assert(res);
        }else

        { /* path already exists; check if the watcher already exists */ - res = add_to_list(&wl, wo, 1); + res = add_to_list(&wl, wo, 0); }

        return res;
        }

        Show
        Peng Futian added a comment - Index: src/c/src/zk_hashtable.c =================================================================== — src/c/src/zk_hashtable.c (修订版 1187635) +++ src/c/src/zk_hashtable.c (工作拷贝) @@ -190,7 +190,7 @@ assert(res); }else { /* path already exists; check if the watcher already exists */ - res = add_to_list(&wl, wo, 1); + res = add_to_list(&wl, wo, 0); } return res; }
        Hide
        Peng Futian added a comment -

        Index: src/c/src/zk_hashtable.c
        ===================================================================
        — src/c/src/zk_hashtable.c (修订版 1187635)
        +++ src/c/src/zk_hashtable.c (工作拷贝)
        @@ -190,7 +190,7 @@
        assert(res);
        }else

        { /* path already exists; check if the watcher already exists */ - res = add_to_list(&wl, wo, 1); + res = add_to_list(&wl, wo, 0); }

        return res;
        }

        Show
        Peng Futian added a comment - Index: src/c/src/zk_hashtable.c =================================================================== — src/c/src/zk_hashtable.c (修订版 1187635) +++ src/c/src/zk_hashtable.c (工作拷贝) @@ -190,7 +190,7 @@ assert(res); }else { /* path already exists; check if the watcher already exists */ - res = add_to_list(&wl, wo, 1); + res = add_to_list(&wl, wo, 0); } return res; }

          People

          • Assignee:
            Peng Futian
            Reporter:
            Peng Futian
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development