Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.6.0
    • Component/s: c client
    • Labels:
    • Environment:

      Linux phy 2.6.18-53.el5 #1 SMP Wed Oct 10 16:34:19 EDT 2007 x86_64 x86_64 x86_64 GNU/Linux
      gcc version 4.1.2 20070626 (Red Hat 4.1.2-14)

    • Release Note:
      Fix compile error under RedHat linux
    • Tags:
      c client

      Description

      When I compile zookeeper c client in my project, there are some error:
      ../../../include/zookeeper/recordio.h:70: error:expected unqualified-id before '_extension_'
      ../../../include/zookeeper/recordio.h:70: error:expected `)' before '_extension_'
      ../../.. /include/zookeeper/recordio.h:70: error:expected unqualified-id before ')' token

        Activity

        Hide
        Flavio Junqueira added a comment -

        Since I got no feedback, I'm moving this one to 3.5.0.

        Show
        Flavio Junqueira added a comment - Since I got no feedback, I'm moving this one to 3.5.0.
        Hide
        Flavio Junqueira added a comment -

        It has been a long time, is this still an issue?

        Show
        Flavio Junqueira added a comment - It has been a long time, is this still an issue?
        Hide
        Mahadev konar added a comment -

        Moving it out, not a critical bugfix.

        Show
        Mahadev konar added a comment - Moving it out, not a critical bugfix.
        Hide
        Mahadev konar added a comment -

        Peng,
        Could you please re upload the patch with a license grant?

        Show
        Mahadev konar added a comment - Peng, Could you please re upload the patch with a license grant?
        Hide
        Mahadev konar added a comment -

        I am taking this out of 3.4.1. If the patch becomes available before I cut a 3.4.1 Ill incorporate it.

        Show
        Mahadev konar added a comment - I am taking this out of 3.4.1. If the patch becomes available before I cut a 3.4.1 Ill incorporate it.
        Hide
        Mahadev konar added a comment -

        Peng,
        Can you please re upload the patch and grant license to Apache for inclusion?

        Thanks

        Show
        Mahadev konar added a comment - Peng, Can you please re upload the patch and grant license to Apache for inclusion? Thanks
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12500278/ZOOKEEPER-1240.patch
        against trunk revision 1208979.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/818//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/818//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/818//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500278/ZOOKEEPER-1240.patch against trunk revision 1208979. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/818//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/818//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/818//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12500278/ZOOKEEPER-1240.patch
        against trunk revision 1188523.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/653//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/653//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/653//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500278/ZOOKEEPER-1240.patch against trunk revision 1188523. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/653//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/653//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/653//console This message is automatically generated.
        Hide
        Peng Futian added a comment -

        @Mahadev konar,
        I am sorry,Can you help me finished this issue?Thank you very much.
        I just want you know there are a issue.

        Show
        Peng Futian added a comment - @Mahadev konar, I am sorry,Can you help me finished this issue?Thank you very much. I just want you know there are a issue.
        Hide
        Mahadev konar added a comment -

        Peng,
        You seem to have closed the jira again? Take a look at how to contribute, on the https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute for guidance on how to upload/review/get it committed.

        Show
        Mahadev konar added a comment - Peng, You seem to have closed the jira again? Take a look at how to contribute, on the https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute for guidance on how to upload/review/get it committed.
        Hide
        Peng Futian added a comment -

        Index: src/c/include/recordio.h
        ===================================================================
        — src/c/include/recordio.h (修订版 1187635)
        +++ src/c/include/recordio.h (工作拷贝)
        @@ -72,9 +72,9 @@
        void close_buffer_iarchive(struct iarchive **ia);
        char *get_buffer(struct oarchive *);
        int get_buffer_len(struct oarchive *);
        -
        +#ifndef htonll
        int64_t htonll(int64_t v);
        -
        +#endif
        #ifdef __cplusplus
        }
        #endif

        Show
        Peng Futian added a comment - Index: src/c/include/recordio.h =================================================================== — src/c/include/recordio.h (修订版 1187635) +++ src/c/include/recordio.h (工作拷贝) @@ -72,9 +72,9 @@ void close_buffer_iarchive(struct iarchive **ia); char *get_buffer(struct oarchive *); int get_buffer_len(struct oarchive *); - +#ifndef htonll int64_t htonll(int64_t v); - +#endif #ifdef __cplusplus } #endif
        Hide
        Peng Futian added a comment -

        Index: src/c/include/recordio.h
        ===================================================================
        — src/c/include/recordio.h (修订版 1187635)
        +++ src/c/include/recordio.h (工作拷贝)
        @@ -72,9 +72,9 @@
        void close_buffer_iarchive(struct iarchive **ia);
        char *get_buffer(struct oarchive *);
        int get_buffer_len(struct oarchive *);
        -
        +#ifndef htonll
        int64_t htonll(int64_t v);
        -
        +#endif
        #ifdef __cplusplus
        }
        #endif

        Show
        Peng Futian added a comment - Index: src/c/include/recordio.h =================================================================== — src/c/include/recordio.h (修订版 1187635) +++ src/c/include/recordio.h (工作拷贝) @@ -72,9 +72,9 @@ void close_buffer_iarchive(struct iarchive **ia); char *get_buffer(struct oarchive *); int get_buffer_len(struct oarchive *); - +#ifndef htonll int64_t htonll(int64_t v); - +#endif #ifdef __cplusplus } #endif
        Hide
        Peng Futian added a comment -

        fix compile error under RedHat Linux

        Show
        Peng Futian added a comment - fix compile error under RedHat Linux

          People

          • Assignee:
            Peng Futian
            Reporter:
            Peng Futian
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development