ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1229

C client hashtable_remove redundantly calls hash function

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.5.0
    • Component/s: c client
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      hashtable_remove appears to call the hash function in consecutive lines. As hash functions are generally cpu intensive, using the hashvalue returned from the first call will result in a performance improvement.

      void * /* returns value associated with key */
      hashtable_remove(struct hashtable *h, void *k)
      ...
          unsigned int hashvalue, index;
      
          hashvalue = hash(h,k);
          index = indexFor(h->tablelength,hash(h,k));
          pE = &(h->table[index]);
          e = *pE;
      

        Activity

        Eric Abbott created issue -
        Harsh J made changes -
        Field Original Value New Value
        Labels newbie
        Harsh J made changes -
        Attachment ZOOKEEPER-1229.patch [ 12508913 ]
        Harsh J made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Harsh J made changes -
        Assignee Harsh J [ qwertymaniac ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12508913/ZOOKEEPER-1229.patch
        against trunk revision 1225352.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/872//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/872//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/872//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508913/ZOOKEEPER-1229.patch against trunk revision 1225352. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/872//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/872//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/872//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Good one. Thanks Harsh.

        Show
        Patrick Hunt added a comment - Good one. Thanks Harsh.
        Patrick Hunt made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1413 (See https://builds.apache.org/job/ZooKeeper-trunk/1413/)
        ZOOKEEPER-1229. C client hashtable_remove redundantly calls hash function (Harsh J via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225919
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/src/hashtable/hashtable.c
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1413 (See https://builds.apache.org/job/ZooKeeper-trunk/1413/ ) ZOOKEEPER-1229 . C client hashtable_remove redundantly calls hash function (Harsh J via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225919 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/src/hashtable/hashtable.c

          People

          • Assignee:
            Harsh J
            Reporter:
            Eric Abbott
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development