Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      • fix ordering of class members
      • Remove Interface Session and rename inner class SessionImpl to Session
      • make properties private final where possible
      • rename SessionTrackerImpl to LeaderSessionTracker. There's a LearnerSessionTracker, so it makes sense.
      • make the following code clearer, what does the bitshifting do?
            public static long initializeNextSession(long id) {
                long nextSid = 0;
                nextSid = (System.currentTimeMillis() << 24) >> 8;
                nextSid =  nextSid | (id <<56);
                return nextSid;
            }
        
      • replace the inner class SessionSet by a normal Set
      • make SessionTrackerImpl an instance of Runnable

        Issue Links

          Activity

          Gavin made changes -
          Link This issue is depended upon by ZOOKEEPER-1285 [ ZOOKEEPER-1285 ]
          Gavin made changes -
          Link This issue blocks ZOOKEEPER-1285 [ ZOOKEEPER-1285 ]
          Thomas Koch made changes -
          Field Original Value New Value
          Link This issue blocks ZOOKEEPER-1285 [ ZOOKEEPER-1285 ]
          Thomas Koch created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Thomas Koch
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development