ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1212

zkServer.sh stop action is not conformat with LSB para 20.2 Init Script Actions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3, 3.4.0, 3.5.0
    • Fix Version/s: 3.3.4, 3.4.0, 3.5.0
    • Component/s: scripts
    • Labels:
      None

      Description

      According to LSB Core para 20.2:
      ==================================================================================
      Otherwise,  the exit  status shall  be non­zero,  as de­fined below. 
      In addition to straightforward success, the following situations are
      also to be considered successful: 
      • restarting a service (instead of reloading it) with the force­reload argument
      • running start on a service already running
      • running stop on a service already stopped or not running
      • running restart on a service already stopped or not running
      • running try­restart on a service already stopped or not running
      ==================================================================================

      Yet, zkServer.sh fails on stop if it can't find a PID file:

      stop)
          echo -n "Stopping zookeeper ... "
          if [ ! -f "$ZOOPIDFILE" ]
          then
            echo "error: could not find file $ZOOPIDFILE"
            exit 1
          else
            $KILL -9 $(cat "$ZOOPIDFILE")
            rm "$ZOOPIDFILE"
            echo STOPPED
            exit 0
          fi
      
      1. ZOOKEEPER-1212-3.3.patch.txt
        0.4 kB
        Roman Shaposhnik
      2. ZOOKEEPER-1212.patch.txt
        0.5 kB
        Roman Shaposhnik

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12497538/ZOOKEEPER-1212.patch.txt
        against trunk revision 1177432.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497538/ZOOKEEPER-1212.patch.txt against trunk revision 1177432. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        I don't think we were aware of these guidelines when we originally created this script (also, it wasn't originally intended to be used as an init script). Sounds reasonable though.

        Show
        Patrick Hunt added a comment - I don't think we were aware of these guidelines when we originally created this script (also, it wasn't originally intended to be used as an init script). Sounds reasonable though.
        Hide
        Patrick Hunt added a comment -

        Roman this is committed for 3.4/3.5 but it's failing to apply to 3.3, please submit an additional patch for that.

        Show
        Patrick Hunt added a comment - Roman this is committed for 3.4/3.5 but it's failing to apply to 3.3, please submit an additional patch for that.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1325 (See https://builds.apache.org/job/ZooKeeper-trunk/1325/)
        ZOOKEEPER-1212. zkServer.sh stop action is not conformat with LSB para 20.2 Init Script Actions (Roman Shaposhnik via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179336
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/bin/zkServer.sh
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1325 (See https://builds.apache.org/job/ZooKeeper-trunk/1325/ ) ZOOKEEPER-1212 . zkServer.sh stop action is not conformat with LSB para 20.2 Init Script Actions (Roman Shaposhnik via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179336 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/bin/zkServer.sh
        Hide
        Roman Shaposhnik added a comment -

        @Patrick, patch for the 3.3 branch attached (why did you guys undo all the formating for shell scripts?)

        Show
        Roman Shaposhnik added a comment - @Patrick, patch for the 3.3 branch attached (why did you guys undo all the formating for shell scripts?)
        Hide
        Mahadev konar added a comment -

        I just committed this to 3.3 branch. Thanks Roman.

        Show
        Mahadev konar added a comment - I just committed this to 3.3 branch. Thanks Roman.

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development