ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1203

Zookeeper systest is missing Junit Classes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.4, 3.4.0, 3.5.0
    • Component/s: tests
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      For running these tests, I am following instructions on https://github.com/apache/zookeeper/blob/trunk/src/java/systest/README.txt

      In Step 4, when I try to run java jar build/contrib/fatjar/zookeeper<version>-fatjar.jar systest org.apache.zookeeper.test.system.SimpleSysTest , it throws the following error,

      Exception in thread "main" java.lang.NoClassDefFoundError: junit/framework/TestCase

      The problem is that zookeeper-dev-fatjar.jar does not contain the TestCase class.

      Patrick Hunt suggested that adding <zipgroupfileset dir="$

      {zk.root}

      /build/test/lib" includes="*.jar" /> to fatjar/build.xml should solve the problem and it does.

        Activity

        Hide
        Patrick Hunt added a comment -

        committed. Thanks Prashant!

        Show
        Patrick Hunt added a comment - committed. Thanks Prashant!
        Hide
        Mahadev konar added a comment -

        Looks like this was committed. Pat did you forget to resolve this?

        Show
        Mahadev konar added a comment - Looks like this was committed. Pat did you forget to resolve this?
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1317 (See https://builds.apache.org/job/ZooKeeper-trunk/1317/)
        ZOOKEEPER-1203. Zookeeper systest is missing Junit Classes (Prashant Gokhale via phunt)

        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176575
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/contrib/fatjar/build.xml
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1317 (See https://builds.apache.org/job/ZooKeeper-trunk/1317/ ) ZOOKEEPER-1203 . Zookeeper systest is missing Junit Classes (Prashant Gokhale via phunt) phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176575 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/contrib/fatjar/build.xml
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12496378/ZK-1203-patch.txt
        against trunk revision 1173949.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12496378/ZK-1203-patch.txt against trunk revision 1173949. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/587//console This message is automatically generated.
        Hide
        Jolly Chen added a comment -

        Patch supplied with suggested fix in the original description.

        Show
        Jolly Chen added a comment - Patch supplied with suggested fix in the original description.

          People

          • Assignee:
            Prashant Gokhale
            Reporter:
            Prashant Gokhale
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development