Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1189

For an invalid snapshot file(less than 10bytes size) RandomAccessFile stream is leaking.

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.3.3
    • 3.3.4, 3.4.0, 3.5.0
    • server
    • None
    • Incompatible change, Reviewed

    Description

      When loading the snapshot, ZooKeeper will consider only the 'snapshots with atleast 10 bytes size'. Otherwsie it will ignore and just return without closing the RandomAccessFile.

      Util.isValidSnapshot() having the following logic. 
             // Check for a valid snapshot
              RandomAccessFile raf = new RandomAccessFile(f, "r");
              // including the header and the last / bytes
              // the snapshot should be atleast 10 bytes
              if (raf.length() < 10) {
                  return false;
              }
      

      Since the snapshot file validation logic is outside try block, it won't go to the finally block and will be leaked.

      Suggestion: Move the validation logic to the try/catch block.

      Attachments

        1. ZOOKEEPER-1189.1.patch
          2 kB
          Rakesh Radhakrishnan
        2. ZOOKEEPER-1189.patch
          2 kB
          Rakesh Radhakrishnan
        3. ZOOKEEPER-1189-branch-3.3.patch
          2 kB
          Rakesh Radhakrishnan

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rakeshr Rakesh Radhakrishnan
            rakeshr Rakesh Radhakrishnan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment