[ZOOKEEPER-1185] Send AuthFailed event to client if SASL authentication fails - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.4.0
Fix Version/s: 3.4.0, 3.5.0
Component/s: java client
Labels:
- kerberos
- security

Release Note:

Hide
This patch fixes SaslAuthFailTest.testBadSaslAuthNotifiesWatch() to test for the AuthFailed event : previously, the test was incorrectly not testing for this event.

It also removes the testBadSaslAuthNotifiesWatch() method from the SaslAuthTest class : this method belongs in SaslAuthFailTest, not SaslAuthTest. The former tests unsuccessful SASL authentication; the latter, successful SASL authentication.

Show
This patch fixes SaslAuthFailTest.testBadSaslAuthNotifiesWatch() to test for the AuthFailed event : previously, the test was incorrectly not testing for this event. It also removes the testBadSaslAuthNotifiesWatch() method from the SaslAuthTest class : this method belongs in SaslAuthFailTest, not SaslAuthTest. The former tests unsuccessful SASL authentication; the latter, successful SASL authentication.

Description

There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate).

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

ZOOKEEPER-1185.patch
15/Sep/11 01:17
5 kB
Eugene Joseph Koontz
ZOOKEEPER-1185.patch
27/Sep/11 01:30
5 kB
Mahadev Konar

Issue Links

depends upon

ZOOKEEPER-938 Support Kerberos authentication of clients.

Closed

Activity

People

Assignee:: Eugene Joseph Koontz

Reporter:: Eugene Joseph Koontz

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 15/Sep/11 01:11

Updated:: 02/May/13 02:29

Resolved:: 27/Sep/11 02:09