ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1185

Send AuthFailed event to client if SASL authentication fails

    Details

    • Release Note:
      Hide
      This patch fixes SaslAuthFailTest.testBadSaslAuthNotifiesWatch() to test for the AuthFailed event : previously, the test was incorrectly not testing for this event.

      It also removes the testBadSaslAuthNotifiesWatch() method from the SaslAuthTest class : this method belongs in SaslAuthFailTest, not SaslAuthTest. The former tests unsuccessful SASL authentication; the latter, successful SASL authentication.
      Show
      This patch fixes SaslAuthFailTest.testBadSaslAuthNotifiesWatch() to test for the AuthFailed event : previously, the test was incorrectly not testing for this event. It also removes the testBadSaslAuthNotifiesWatch() method from the SaslAuthTest class : this method belongs in SaslAuthFailTest, not SaslAuthTest. The former tests unsuccessful SASL authentication; the latter, successful SASL authentication.

      Description

      There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate).

      1. ZOOKEEPER-1185.patch
        5 kB
        Eugene Koontz
      2. ZOOKEEPER-1185.patch
        5 kB
        Mahadev konar

        Issue Links

          Activity

          Eugene Koontz created issue -
          Eugene Koontz made changes -
          Field Original Value New Value
          Status Open [ 1 ] Patch Available [ 10002 ]
          Release Note This patch fixes SaslAuthFailTest.testBadSaslAuthNotifiesWatch() to test for the AuthFailed event : previously, the test was incorrectly not testing for this event.

          It also removes the testBadSaslAuthNotifiesWatch() method from the SaslAuthTest class : this method belongs in SaslAuthFailTest, not SaslAuthTest. The former tests unsuccessful SASL authentication; the latter, successful SASL authentication.
          Eugene Koontz made changes -
          Attachment ZOOKEEPER-1185.patch [ 12494547 ]
          Eugene Koontz made changes -
          Link This issue depends on ZOOKEEPER-938 [ ZOOKEEPER-938 ]
          Patrick Hunt made changes -
          Fix Version/s 3.5.0 [ 12316644 ]
          Mahadev konar made changes -
          Attachment ZOOKEEPER-1185.patch [ 12496613 ]
          Mahadev konar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Mahadev konar made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue depends on ZOOKEEPER-938 [ ZOOKEEPER-938 ]
          Gavin made changes -
          Link This issue depends upon ZOOKEEPER-938 [ ZOOKEEPER-938 ]

            People

            • Assignee:
              Eugene Koontz
              Reporter:
              Eugene Koontz
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development