[ZOOKEEPER-1176] Remove dead code and basic cleanup in DataTree

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.5.0
• Hadoop Flags: Reviewed
• Tags: cleanup, cleancode
• Assignee: Thomas Koch
• Reporter: Thomas Koch
• Created: 09/Sep/11 15:44
• Updated: 17/Sep/11 10:56
• Resolved: 17/Sep/11 00:36

Description

• DataTree members scount, initialized and method listACLEquals are never used
• transform if(!C) B else A to if(C) A else B (removes one indirection to follow for the brain)
• remove unused imports and one annotation
• add method getApproximateDataSize to DataNode (I work towards an immutable DataNode without public properties)
• move assignments (lastPrefix = getMaxPrefixWithQuota(path)) out of if statements
• combine nested if statements: if A if B then C => if A && B => C
• make ACL maps private and add getAclSize() to hide implementation details of the ACLs.