Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Native C# client for ZooKeeper.

      1. log4net.dll
        264 kB
        Eric Hauser
      2. nunit.framework.dll
        132 kB
        Eric Hauser
      3. ZOOKEEPER-1158-09032011.patch
        1.70 MB
        Eric Hauser
      4. ZOOKEEPER-1158-09082011-2.patch
        411 kB
        Eric Hauser

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12491031/ZOOKEEPER-1158.patch
        against trunk revision 1159432.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 34 release audit warnings (more than the trunk's current 24 warnings).

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491031/ZOOKEEPER-1158.patch against trunk revision 1159432. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 34 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/470//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        Eric,
        Thanks for the submission. Would you be able to add more details to the patch? How does it work? How to use it? Does it use the C serialization or you added generation for C#?

        Show
        Mahadev konar added a comment - Eric, Thanks for the submission. Would you be able to add more details to the patch? How does it work? How to use it? Does it use the C serialization or you added generation for C#?
        Hide
        Eric Hauser added a comment -

        It is a native C# port of the Java client that uses support for C# that was added to jute. In most cases, the API was intentionally keep the same as the Java client in order to make future porting easier.

        I've added a second patch that adds the code generation necessary to compile to build.xml.

        Show
        Eric Hauser added a comment - It is a native C# port of the Java client that uses support for C# that was added to jute. In most cases, the API was intentionally keep the same as the Java client in order to make future porting easier. I've added a second patch that adds the code generation necessary to compile to build.xml.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12492697/ZOOKEEPER-1158_2.patch
        against trunk revision 1164265.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492697/ZOOKEEPER-1158_2.patch against trunk revision 1164265. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/486//console This message is automatically generated.
        Hide
        Camille Fournier added a comment -

        Eric,

        Very exciting, thanks so much for pushing this back. I think we need to get a .NET build for our build farm. We're already working on a windows C++ build so hopefully this won't be too difficult. Which version of .NET is this written against, 4.0?
        I'm going to have my team here try to apply and compile the patch. We use 3.5 though, so not sure we will be successful. Either way I think we can do the code review since we're already using the old SharpKeeper

        BTW, the second patch should probably be submitted on top of the first, instead of as a separate thing.

        Show
        Camille Fournier added a comment - Eric, Very exciting, thanks so much for pushing this back. I think we need to get a .NET build for our build farm. We're already working on a windows C++ build so hopefully this won't be too difficult. Which version of .NET is this written against, 4.0? I'm going to have my team here try to apply and compile the patch. We use 3.5 though, so not sure we will be successful. Either way I think we can do the code review since we're already using the old SharpKeeper BTW, the second patch should probably be submitted on top of the first, instead of as a separate thing.
        Hide
        Eric Hauser added a comment -

        Camille,

        The patch makes is .NET 4.0 based. .NET 4.0 contains some lockless collections that lead to a significant performance improvement over the previous version of my client. If necessary, this could be handled using compiler flags. Although I have not testing this client vs. Mono, I know that the Avro project includes a nant script to compile and run their C# tests under mono.

        I've concatenated the two patches and attached.

        Show
        Eric Hauser added a comment - Camille, The patch makes is .NET 4.0 based. .NET 4.0 contains some lockless collections that lead to a significant performance improvement over the previous version of my client. If necessary, this could be handled using compiler flags. Although I have not testing this client vs. Mono, I know that the Avro project includes a nant script to compile and run their C# tests under mono. I've concatenated the two patches and attached.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12492907/ZOOKEEPER-1158-09032011.patch
        against trunk revision 1164758.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 36 release audit warnings (more than the trunk's current 24 warnings).

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492907/ZOOKEEPER-1158-09032011.patch against trunk revision 1164758. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 36 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/495//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        The following files need apache licenses added (see the other source for examples):

        More details: http://www.apache.org/legal/src-headers.html

        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/DistributedQueueTests.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/Properties/AssemblyInfo.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/WriteLockTests.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/ZNodeNameTests.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/ZooKeeperNetRecipes.Tests.csproj
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/DistributedQueue.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/Properties/AssemblyInfo.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/ProtocolSupport.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/SortedSet.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/WriteLock.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/ZNodeName.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/ZooKeeperNet.Recipes.csproj
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Tests/App.config
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Tests/CountDownLatch.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Tests/SocketTests.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Tests/ZooKeeperNet.Tests.csproj
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet/ClientConnectionRequestProducer.cs
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet/ZooKeeperNet.csproj
        [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/lib/log4net.xml
        
        Show
        Patrick Hunt added a comment - The following files need apache licenses added (see the other source for examples): More details: http://www.apache.org/legal/src-headers.html [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/DistributedQueueTests.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/Properties/AssemblyInfo.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/WriteLockTests.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/ZNodeNameTests.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes.Tests/ZooKeeperNetRecipes.Tests.csproj [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/DistributedQueue.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/Properties/AssemblyInfo.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/ProtocolSupport.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/SortedSet.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/WriteLock.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/ZNodeName.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Recipes/ZooKeeperNet.Recipes.csproj [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Tests/App.config [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Tests/CountDownLatch.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Tests/SocketTests.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet.Tests/ZooKeeperNet.Tests.csproj [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet/ClientConnectionRequestProducer.cs [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/ZooKeeperNet/ZooKeeperNet.csproj [rat:report] !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build/zookeeper-3.4.0/src/dotnet/lib/log4net.xml
        Hide
        Patrick Hunt added a comment -

        it might be the some of the files (csproj for example) may not support adding license details, if that's the case please update build.xml with the exclusions in releaseaudit target.

        Show
        Patrick Hunt added a comment - it might be the some of the files (csproj for example) may not support adding license details, if that's the case please update build.xml with the exclusions in releaseaudit target.
        Hide
        Camille Fournier added a comment -

        Some comments from our side of the fence on the first patch, please disregard those that are not relevant with the updates:

        • After applying the patch, a lot of the files seem to have weird characters (maybe need a dos2unix?). I’ve seen them in svn diffs before so thought it may be normal but doesn’t seem like it. Had to manually remove them.
        • The csproj doesn’t fully correspond to the jute generated files; there’s an extra file required by the csproj which jute doesn’t generate. Luckily it’s not required by the code, just a bad csproj.
        • Mismatch between code and jute templates (jute generates ZooKeeperNet.Conversion but real namespace is ZooKeeperNet.IO).
        • Strong naming keys or dependent dll’s aren’t part of the patch but I think that’s likely due to the fact that patches can’t contain binaries but it does mean I had to source the dll’s from somewhere and disable strong naming for now.
        • One of the csproj’s has a reference to pnunit. I’ve no idea what it is but it doesn’t seem required. Again, bad csproj.
        • Some weird nunit stuff, he uses Assert.True but I’ve only ever seen (and the only version my nunit has) is Assert.IsTrue.
        • Tests require a locally running ZooKeeper server which is annoying and means there’s currently no way of running the tests automatically as the build.xml does nothing for .Net other than running jute.

        We did manage to work through these and get the unit tests to pass, so I think it's all quite promising. We also have a few small enhancements that we made over the old SharpKeeper that don't seem to exist here either but we can add those in once this is committed.

        Show
        Camille Fournier added a comment - Some comments from our side of the fence on the first patch, please disregard those that are not relevant with the updates: • After applying the patch, a lot of the files seem to have weird characters (maybe need a dos2unix?). I’ve seen them in svn diffs before so thought it may be normal but doesn’t seem like it. Had to manually remove them. • The csproj doesn’t fully correspond to the jute generated files; there’s an extra file required by the csproj which jute doesn’t generate. Luckily it’s not required by the code, just a bad csproj. • Mismatch between code and jute templates (jute generates ZooKeeperNet.Conversion but real namespace is ZooKeeperNet.IO). • Strong naming keys or dependent dll’s aren’t part of the patch but I think that’s likely due to the fact that patches can’t contain binaries but it does mean I had to source the dll’s from somewhere and disable strong naming for now. • One of the csproj’s has a reference to pnunit. I’ve no idea what it is but it doesn’t seem required. Again, bad csproj. • Some weird nunit stuff, he uses Assert.True but I’ve only ever seen (and the only version my nunit has) is Assert.IsTrue. • Tests require a locally running ZooKeeper server which is annoying and means there’s currently no way of running the tests automatically as the build.xml does nothing for .Net other than running jute. We did manage to work through these and get the unit tests to pass, so I think it's all quite promising. We also have a few small enhancements that we made over the old SharpKeeper that don't seem to exist here either but we can add those in once this is committed.
        Hide
        Camille Fournier added a comment -

        One other comment:
        The Perms values are currently static rather than const. It would be better if they were const so we could use them in switch statements.

        Show
        Camille Fournier added a comment - One other comment: The Perms values are currently static rather than const. It would be better if they were const so we could use them in switch statements.
        Hide
        Eric Hauser added a comment -

        New patch submitted addressing the issues listed above.

        A couple of notes:

        1. The additional binary assemblies have been added to the ticket and they need to be placed in src/dotnet/lib. As opposed to checking the assemblies in directly, we could just add reference using NuGet (.NET's Maven/Ivy equivalent). However, Andrew is working on a Mono build for this and I am not sure if NuGet works with Mono.
        2. Having the strong named keys generated by a NAnt script sounds like a fine idea. I would probably prefer to commit this patch and address that in a follow up issue given the size of this patch.

        Show
        Eric Hauser added a comment - New patch submitted addressing the issues listed above. A couple of notes: 1. The additional binary assemblies have been added to the ticket and they need to be placed in src/dotnet/lib. As opposed to checking the assemblies in directly, we could just add reference using NuGet (.NET's Maven/Ivy equivalent). However, Andrew is working on a Mono build for this and I am not sure if NuGet works with Mono. 2. Having the strong named keys generated by a NAnt script sounds like a fine idea. I would probably prefer to commit this patch and address that in a follow up issue given the size of this patch.
        Hide
        Joshua Garvin added a comment -

        I'm curious if anyone can tell me when this patch will be added to the repository. I could really use this code and when I checked out the repository and tried to apply the attached patches, it told me there was an unknown line type on line 4738.

        Show
        Joshua Garvin added a comment - I'm curious if anyone can tell me when this patch will be added to the repository. I could really use this code and when I checked out the repository and tried to apply the attached patches, it told me there was an unknown line type on line 4738.
        Hide
        Flavio Junqueira added a comment -

        Joshua, This issue is marked for 3.5.0, so it should go into the next release, not the one we are working on currently.

        Show
        Flavio Junqueira added a comment - Joshua, This issue is marked for 3.5.0, so it should go into the next release, not the one we are working on currently.
        Hide
        Maxime Brugidou added a comment -

        Eric, the nuget.exe executable works on Mono. So we could use it to load the 2 referenced dlls. Although I haven't tested.

        I did a pull request on your github in case you want to use that patch (https://github.com/ewhauser/zookeeper/pull/1).

        The .NET zookeeper client is also available via NuGet at https://nuget.org/packages/ZooKeeperNet

        Show
        Maxime Brugidou added a comment - Eric, the nuget.exe executable works on Mono. So we could use it to load the 2 referenced dlls. Although I haven't tested. I did a pull request on your github in case you want to use that patch ( https://github.com/ewhauser/zookeeper/pull/1 ). The .NET zookeeper client is also available via NuGet at https://nuget.org/packages/ZooKeeperNet

          People

          • Assignee:
            Eric Hauser
            Reporter:
            Eric Hauser
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:

              Development