Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I propose we mark these as deprecated in 3.4.0 and remove them in the following release.

      1. ZOOKEEPER-1153.patch
        4 kB
        Flavio Junqueira
      2. ZOOKEEPER-1153.patch
        3 kB
        Flavio Junqueira

        Activity

        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1288 (See https://builds.apache.org/job/ZooKeeper-trunk/1288/)
        ZOOKEEPER-1153. Deprecate AuthFLE and LE. (Flavio Junqueira via mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163099
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/docs/bookkeeperConfig.pdf
        • /zookeeper/trunk/docs/bookkeeperOverview.pdf
        • /zookeeper/trunk/docs/bookkeeperProgrammer.pdf
        • /zookeeper/trunk/docs/bookkeeperStarted.pdf
        • /zookeeper/trunk/docs/bookkeeperStream.pdf
        • /zookeeper/trunk/docs/index.pdf
        • /zookeeper/trunk/docs/javaExample.pdf
        • /zookeeper/trunk/docs/linkmap.pdf
        • /zookeeper/trunk/docs/recipes.pdf
        • /zookeeper/trunk/docs/releasenotes.pdf
        • /zookeeper/trunk/docs/zookeeperAdmin.html
        • /zookeeper/trunk/docs/zookeeperAdmin.pdf
        • /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.pdf
        • /zookeeper/trunk/docs/zookeeperInternals.pdf
        • /zookeeper/trunk/docs/zookeeperJMX.pdf
        • /zookeeper/trunk/docs/zookeeperObservers.pdf
        • /zookeeper/trunk/docs/zookeeperOver.pdf
        • /zookeeper/trunk/docs/zookeeperProgrammers.pdf
        • /zookeeper/trunk/docs/zookeeperQuotas.pdf
        • /zookeeper/trunk/docs/zookeeperStarted.pdf
        • /zookeeper/trunk/docs/zookeeperTutorial.pdf
        • /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java
        • /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1288 (See https://builds.apache.org/job/ZooKeeper-trunk/1288/ ) ZOOKEEPER-1153 . Deprecate AuthFLE and LE. (Flavio Junqueira via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163099 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/docs/bookkeeperConfig.pdf /zookeeper/trunk/docs/bookkeeperOverview.pdf /zookeeper/trunk/docs/bookkeeperProgrammer.pdf /zookeeper/trunk/docs/bookkeeperStarted.pdf /zookeeper/trunk/docs/bookkeeperStream.pdf /zookeeper/trunk/docs/index.pdf /zookeeper/trunk/docs/javaExample.pdf /zookeeper/trunk/docs/linkmap.pdf /zookeeper/trunk/docs/recipes.pdf /zookeeper/trunk/docs/releasenotes.pdf /zookeeper/trunk/docs/zookeeperAdmin.html /zookeeper/trunk/docs/zookeeperAdmin.pdf /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.pdf /zookeeper/trunk/docs/zookeeperInternals.pdf /zookeeper/trunk/docs/zookeeperJMX.pdf /zookeeper/trunk/docs/zookeeperObservers.pdf /zookeeper/trunk/docs/zookeeperOver.pdf /zookeeper/trunk/docs/zookeeperProgrammers.pdf /zookeeper/trunk/docs/zookeeperQuotas.pdf /zookeeper/trunk/docs/zookeeperStarted.pdf /zookeeper/trunk/docs/zookeeperTutorial.pdf /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
        Hide
        Mahadev konar added a comment -

        Just pushed this. Thanks Flavio!

        Show
        Mahadev konar added a comment - Just pushed this. Thanks Flavio!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12490526/ZOOKEEPER-1153.patch
        against trunk revision 1157698.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/462//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/462//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/462//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490526/ZOOKEEPER-1153.patch against trunk revision 1157698. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/462//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/462//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/462//console This message is automatically generated.
        Hide
        Flavio Junqueira added a comment -

        Some small improvements.

        Show
        Flavio Junqueira added a comment - Some small improvements.
        Hide
        Flavio Junqueira added a comment -

        It marks three classes as deprecated and modifies documentation to reflect it.

        Show
        Flavio Junqueira added a comment - It marks three classes as deprecated and modifies documentation to reflect it.
        Hide
        Flavio Junqueira added a comment -

        There are two small tasks here:

        1. Add the @Deprecated tag to the AuthFLE and to the LE classes;
        2. Modify the documentation to reflect this change. In particular, we need to modify the administrator's guide in the part that discusses the options for electionAlg.
        Show
        Flavio Junqueira added a comment - There are two small tasks here: Add the @Deprecated tag to the AuthFLE and to the LE classes; Modify the documentation to reflect this change. In particular, we need to modify the administrator's guide in the part that discusses the options for electionAlg.

          People

          • Assignee:
            Flavio Junqueira
            Reporter:
            Flavio Junqueira
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development