ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1141

zkpython fails tests under python 2.4

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 3.4.0
        • Fix Version/s: 3.4.0
        • Component/s: contrib-bindings
        • Labels:
          None
        • Hadoop Flags:
          Reviewed
        • Tags:
          python

          Description

          "ant test" under python 2.4 is failing due to a small issue in the test code - using a new feature introduced in 2.5.

          I have a small patch which addresses this, after which I was able to compile and run the tests successfully under python 2.4.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Patrick Hunt added a comment -

            small change to the tests which allow them to pass under 2.4 python.

            Show
            Patrick Hunt added a comment - small change to the tests which allow them to pass under 2.4 python.
            Hide
            Permalink
            Hadoop QA added a comment -

            +1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12489134/ZOOKEEPER-1141.patch
            against trunk revision 1152141.

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 6 new or modified tests.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed core unit tests.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/445//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/445//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/445//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12489134/ZOOKEEPER-1141.patch against trunk revision 1152141. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/445//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/445//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/445//console This message is automatically generated.
            Hide
            Permalink
            Mahadev konar added a comment -

            +1 the change looks good. I just pushed this. Thanks Pat!

            Show
            Mahadev konar added a comment - +1 the change looks good. I just pushed this. Thanks Pat!
            Hide
            Permalink
            Hudson added a comment -

            Integrated in ZooKeeper-trunk #1266 (See https://builds.apache.org/job/ZooKeeper-trunk/1266/)
            ZOOKEEPER-1141. zkpython fails tests under python 2.4. (phunt via mahadev)

            mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1157686
            Files :

            • /zookeeper/trunk/src/contrib/zkpython/src/test/connection_test.py
            • /zookeeper/trunk/src/contrib/zkpython/src/test/zktestbase.py
            • /zookeeper/trunk/CHANGES.txt
            Show
            Hudson added a comment - Integrated in ZooKeeper-trunk #1266 (See https://builds.apache.org/job/ZooKeeper-trunk/1266/ ) ZOOKEEPER-1141 . zkpython fails tests under python 2.4. (phunt via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1157686 Files : /zookeeper/trunk/src/contrib/zkpython/src/test/connection_test.py /zookeeper/trunk/src/contrib/zkpython/src/test/zktestbase.py /zookeeper/trunk/CHANGES.txt

              People

              • Assignee:
                Patrick Hunt
                Reporter:
                Patrick Hunt
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development