[ZOOKEEPER-1110] c interface zookeeper_close close fd too quickly.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 3.3.3
• Component/s: c client

Environment

linux platform.

• Assignee: Unassigned
• Reporter: xiliu
• Created: 29/Jun/11 05:30
• Updated: 29/Jul/12 05:37
• Resolved: 25/Apr/12 07:55

Description

The correct step about close client is the client send CLOSE_OP to the server, wait for several seconds, the server will process the terminal request and close the fd.
But the zookeeper_close interface is wrong, because the adaptor_send_queue(zh, 3000) (line 2332), will first wait the timeout then send the request.
The right order is first send the request then wait the timeout. I change as follow:
$svn diff src/c/src/zookeeper.c
Index: src/c/src/zookeeper.c
===================================================================
— src/c/src/zookeeper.c (revision 1140451)
+++ src/c/src/zookeeper.c (working copy)
@@ -2329,7 +2329,8 @@

/* make sure the close request is sent; we set timeout to an arbitrary

• (but reasonable) number of milliseconds since we want the call to block*/

• rc=adaptor_send_queue(zh, 3000);
  + rc=adaptor_send_queue(zh, 0);
  + sleep(3);
  }else{
  LOG_INFO(("Freeing zookeeper resources for sessionId=%#llx\n",
  zh->client_id.client_id));