Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1096

Leader communication should listen on specified IP, not wildcard address

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.3, 3.4.0
    • Fix Version/s: 3.4.6, 3.5.0
    • Component/s: server
    • Labels:
      None

      Description

      Server should specify the local address that is used for leader communication and leader election (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was added a year ago. After reviewing the code, we can't think of a reason why only the port would be used with the wildcard interface, when servers are already connecting specifically to that interface anyway.

      I have submitted a patch, but it does not account for all leader election algorithms.

      Probably should have an option to toggle this, for backwards compatibility, although it seems like it would be a bug if this change broke things.

      There is some more information about making it an option here:
      http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/201008.mbox/%3CAANLkTikkT97Djqt3CU=H2+7Gnj_4p28hgCXjh345HiyN@mail.gmail.com%3E

        Attachments

        1. ZOOKEEPER-1096.patch
          1.0 kB
          Jared Cantwell
        2. ZOOKEEPER-1096.patch
          0.9 kB
          Jared Cantwell
        3. ZOOKEEPER-1096.patch
          2 kB
          Germán Blanco
        4. ZOOKEEPER-1096_branch3.4.patch
          4 kB
          Germán Blanco
        5. ZOOKEEPER-1096_branch3.4.patch
          11 kB
          Germán Blanco
        6. ZOOKEEPER-1096.patch
          11 kB
          Germán Blanco
        7. ZOOKEEPER-1096_branch3.4.patch
          10 kB
          Germán Blanco
        8. ZOOKEEPER-1096.patch
          10 kB
          Germán Blanco

          Issue Links

            Activity

              People

              • Assignee:
                abranzyck Germán Blanco
                Reporter:
                jaredc Jared Cantwell
              • Votes:
                4 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: