ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1048

addauth command does not work in cli_mt/cli_st

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.1
    • Fix Version/s: 3.3.6, 3.4.4, 3.5.0
    • Component/s: c client
    • Labels:
    • Environment:

      SUSE_64

    • Tags:
      addauth

      Description

      I can not operation a node with ACL by "addauth" when using cli_st. I have fixed this bug:
      original:else if (startsWith(line, "addauth ")) {
      char *ptr;
      line += 8;
      ptr = strchr(line, ' ');
      if (ptr)

      { *ptr = '\0'; ptr++; }

      zoo_add_auth(zh, line, ptr, ptr ? strlen(ptr) -1 : 0, NULL, NULL);
      now: zoo_add_auth(zh, line, ptr, ptr ? strlen(ptr) : 0, NULL, NULL);
      strlen(ptr) is just ok.

        Activity

        allengao created issue -
        Patrick Hunt made changes -
        Field Original Value New Value
        Fix Version/s 3.3.5 [ 12319081 ]
        Fix Version/s 3.3.4 [ 12316276 ]
        Patrick Hunt made changes -
        Fix Version/s 3.3.6 [ 12320172 ]
        Fix Version/s 3.3.5 [ 12319081 ]
        Hide
        Michi Mutsuzaki added a comment -

        Hi allengao,

        I think you are right. Let me test it out, and I'll check in the fix.

        Thanks!
        --Michi

        Show
        Michi Mutsuzaki added a comment - Hi allengao, I think you are right. Let me test it out, and I'll check in the fix. Thanks! --Michi
        Michi Mutsuzaki made changes -
        Fix Version/s 3.4.4 [ 12319841 ]
        Fix Version/s 3.5.0 [ 12316644 ]
        Michi Mutsuzaki made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1548 (See https://builds.apache.org/job/ZooKeeper-trunk/1548/)
        ZOOKEEPER-1048. addauth command does not work in cli_mt/cli_st (allengao via michim) (Revision 1334548)

        Result = SUCCESS
        michim : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334548
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/src/cli.c
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1548 (See https://builds.apache.org/job/ZooKeeper-trunk/1548/ ) ZOOKEEPER-1048 . addauth command does not work in cli_mt/cli_st (allengao via michim) (Revision 1334548) Result = SUCCESS michim : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334548 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/src/cli.c

          People

          • Assignee:
            Unassigned
            Reporter:
            allengao
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 168h
              168h
              Remaining:
              Remaining Estimate - 168h
              168h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development