[POLYGENE-107] Entity SPI: JSONEntityState cloning logic is flawed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.1
• External issue URL: https://github.com/apache/zest-java/pull/2
• Assignee: Paul Merlin
• Reporter: Tibor Mlynarik
• Created: 27/Jul/15 13:35
• Updated: 22/Aug/15 06:12
• Resolved: 27/Jul/15 17:03

Description

The cloneStateIfGlobalStateLoaded() method of JSONEntityState is called before any change is made to the entity state.

This method starts with the following check:

if( isStateNotCloned() )
{
return;
}
// Do the clone

And the (private) isStateNotCloned() method returns:
status == EntityStatus.LOADED

IOW, the code says that it will clone state if status is loaded, but it does the opposite!

See discussion: http://s.apache.org/1QI