[ZEPPELIN-5717] Fix incorrect editor value gotten by Runner

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.9.0, 0.10.0, 0.10.1
• Fix Version/s: 0.11.0
• Assignee: Sun Shun
• Reporter: Sun Shun
• Created: 13/Apr/22 06:36
• Updated: 18/Apr/22 14:50
• Resolved: 18/Apr/22 14:50

Description

When user runs paragraph with input box, under the runner role, once they press 'enter' key, the paragraph content will be overwritten and lost (become empty).

I am trying to debug, and find that, in such case, the value of selected paragraph is blank, and it will be passed to backend to run via websocket, and backend will persist it as right now runner are also allowed to save paragraph(perhaps they also need to change parameters)

Then with more debugging, found that the value of "paragraph" is incorrect.

Because for user under runner role, the editor is hidden, so the $scope.editor object is not empty and the $scope.editor.getValue() function may return a null value.

So there should be one more condition to judge: if user cannot view editor, it's also expected to get editor value from $scope.paragraph.text as well.

I already fix this issue and will make the commit on git soon.

Issue Links

• links to: GitHub Pull Request #4353